Your message dated Thu, 03 Mar 2022 10:30:17 +0100
with message-id <[email protected]>
and subject line Re: [Pkg-javascript-devel] Bug#1005872: node-istanbul: Remove
libjs-prettify dependency
has caused the Debian Bug report #1005872,
regarding node-istanbul: Remove libjs-prettify dependency
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1005872: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1005872
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: node-istanbul
Version: 0.4.5+ds+~cs56.14.45-1
Severity: normal
Tags: patch
X-Debbugs-Cc: [email protected]
Dear Maintainer,
prettify.js is unmaintanined https://github.com/googlearchive/code-prettify.
node-istanbul has vendored copy of prettify.js and it can that instead of
prettify.js,
Attached is a patch to remove dependency on libjs-prettify and to use
the vendor provided prettify.js. Please let me know
you opinion on this. Thanks.
Regards,
Vignesh
-- System Information:
Debian Release: 11.1
APT prefers stable
APT policy: (700, 'stable'), (650, 'testing'), (600, 'unstable'), (500,
'stable-updates'), (500, 'stable-security')
Architecture: amd64 (x86_64)
Kernel: Linux 5.10.0-9-amd64 (SMP w/8 CPU threads)
Locale: LANG=en_IN, LC_CTYPE=en_IN (charmap=UTF-8), LANGUAGE=en_IN:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages node-istanbul depends on:
pn handlebars <none>
pn libjs-prettify <none>
pn node-abbrev <none>
pn node-archy <none>
pn node-async <none>
pn node-escodegen <none>
pn node-esprima <none>
pn node-glob <none>
pn node-is-stream <none>
pn node-js-yaml <none>
pn node-make-dir <none>
pn node-mkdirp <none>
pn node-nopt <none>
pn node-once <none>
pn node-p-map <none>
pn node-path-key <none>
pn node-resolve <none>
pn node-rimraf <none>
pn node-shebang-command <none>
pn node-strip-bom <none>
pn node-supports-color <none>
pn node-type-fest <none>
pn node-uuid <none>
pn node-which <none>
pn node-wordwrap <none>
pn nodejs <none>
Versions of packages node-istanbul recommends:
pn node-babel7 <none>
pn node-resolve-from <none>
node-istanbul suggests no packages.
>From a6107a79874aea0ad7d985ee11b795670eb03886 Mon Sep 17 00:00:00 2001
From: Vignesh Raman <[email protected]>
Date: Mon, 14 Feb 2022 19:42:18 +0530
Subject: [PATCH] Remove libjs-prettify dependency
Instead of using the unmaintained prettify.js from
https://github.com/googlearchive/code-prettify, use
the vendored prettify.js and remove the libjs-prettify
dependency.
Signed-off-by: Vignesh Raman <[email protected]>
---
debian/control | 2 --
debian/nodejs/links | 6 ++----
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/debian/control b/debian/control
index 8cf1c0a..87e6eab 100644
--- a/debian/control
+++ b/debian/control
@@ -9,7 +9,6 @@ Build-Depends:
, dh-buildinfo
, dh-sequence-nodejs
, handlebars <!nocheck>
- , libjs-prettify
, node-abbrev <!nocheck>
, node-async <!nocheck>
, node-babel7 <!nocheck>
@@ -38,7 +37,6 @@ Architecture: all
Depends:
${misc:Depends}
, handlebars
- , libjs-prettify
, node-abbrev
, node-async
, node-escodegen
diff --git a/debian/nodejs/links b/debian/nodejs/links
index b7773cb..ba51f32 100644
--- a/debian/nodejs/links
+++ b/debian/nodejs/links
@@ -1,5 +1,3 @@
-/usr/share/javascript/prettify/prettify.css
istanbul/lib/assets/vendor/prettify.css
-/usr/share/javascript/prettify/prettify.js
istanbul/lib/assets/vendor/prettify.js
-/usr/share/javascript/prettify/prettify.css
istanbul-reports/lib/html/assets/vendor/prettify.css
-/usr/share/javascript/prettify/prettify.js
istanbul-reports/lib/html/assets/vendor/prettify.js
+/usr/share/nodejs/istanbul-reports/lib/html/assets/vendor/prettify.css
istanbul/lib/assets/vendor/prettify.css
+/usr/share/nodejs/istanbul-reports/lib/html/assets/vendor/prettify.js
istanbul/lib/assets/vendor/prettify.js
istanbul/lib/cli.js /usr/bin/istanbul
--
2.30.2
--- End Message ---
--- Begin Message ---
Hi Vignesh,
Quoting Vignesh Raman (2022-03-03 10:17:12)
> On 16/02/22 7:27 pm, Jonas Smedegaard wrote:
> > Please do *not* hide problems like that.
>
> Agree
[...]
> It works without the patches. I agree with you not to patch this.
>
> Thank you the detailed explanation. You may close this bug.
Excellent. Thanks!
- Jonas
--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature
--- End Message ---
--
Pkg-javascript-devel mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
