[ re-sent with bugreport added back as recipient ]

Quoting Ayoyimika Ajibade (2022-03-15 14:33:21)
> >Do you understand what that change does, more specifically?
> What is by default is that node-eslint-scope explicitly exports some 
> files, while excluding example is the lib/referencer.js file which is 
> required in webpack5 hence, this error from CI 
> https://salsa.debian.org/Ayoyimika/node-axios/-/jobs/2563777 that is 
> the problem. the patch is to add the excluded file 
> https://salsa.debian.org/Ayoyimika/node-eslint-scope/-/commit/feaf8a8ffb7a1b4794d04323b5e265ce058494a0.patch
> 
> >Is it backwards compatible?  What is the risk of breaking something?
> Its doesn't break anything and its backward compatible with webpack5
> 
> what I will do Is re-update node-eslint-scope based on the newly 
> released package to include the patch and forward the patch upstream

Please propose a patch upstream *without* releasing to Debian yet.

It seems to me that upstream provided a limited ABI and that axios or 
webpack is accessing parts of eslint-scope code that is *not* exposed as 
part of that ABI.

Possibly upstream has a good reason for limiting the ABI, and a better 
fix for this issue is to patch axios or webpack to only use the public 
ABI.


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Attachment: signature.asc
Description: signature

-- 
Pkg-javascript-devel mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Reply via email to