On 1/20/23 04:04, Sandra Uwah wrote:
Hello,
Requesting sponsorship for the package node-http-server.
Package details:
Package version: 14.1.1+~cs6.14.34
Package repo: https://salsa.debian.org/sandra_uwah/node-http-server
<https://salsa.debian.org/sandra_uwah/node-http-server>
I have made the package lintian clean and built in a clean environment
using sbuild. Thanks
Hi,
some problems:
* portfinder needs a patch to be used with node-mkdirp 1 (see
attachment)
* autopkgtest fails due to missing dependencies (at least node-qs and
node-mkdirp and maybe node-async and node-debug)
* test depends on deprecated node-request, not easy to replace. Maybe
we should drop test here
* please mark test-only build dependencies with <!nocheck>
Cheers,
Yadd
Description: fix for mkdirp 1
Author: Yadd <[email protected]>
Forwarded: not-needed
Last-Update: 2023-01-20
--- a/portfinder/lib/portfinder.js
+++ b/portfinder/lib/portfinder.js
@@ -13,7 +13,7 @@
path = require('path'),
_async = require('async'),
debug = require('debug'),
- mkdirp = require('mkdirp').mkdirp;
+ mkdirp = require('mkdirp');
var debugTestPort = debug('portfinder:testPort'),
debugGetPort = debug('portfinder:getPort'),
@@ -315,13 +315,11 @@
// against the socket.
//
function createAndTestSocket (dir) {
- mkdirp(dir, options.mod, function (err) {
- if (err) {
- return callback(err);
- }
-
+ mkdirp(dir, options.mod).then( () => {
options.exists = true;
testSocket();
+ }).catch( err => {
+ return callback(err);
});
}
--
Pkg-javascript-devel mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
