Package: nodejs Followup-For: Bug #1030284 X-Debbugs-Cc: t...@mirbsd.de Hi - what do you both think of the attached patch, which brings the ARM stack size into line with almost all other architectures (= 984 KB)?
(there is a reason not to increase the stack size further: there is a static assertion[1] that the stack size plus 256 bytes is not greater than one MB, and I don't feel keen to change that assertion's logic for this bug) [1] - https://sources.debian.org/src/nodejs/18.13.0%2Bdfsg1-1/deps/v8/src/common/globals.h/#L105-L108
Harmonize V8 stack sizes on ARM architectures to match almost all other architectures --- a/deps/v8/src/common/globals.h +++ b/deps/v8/src/common/globals.h @@ -144,14 +144,7 @@ #define ENABLE_SPARKPLUG true -#if V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_ARM64 -// Set stack limit lower for ARM and ARM64 than for other architectures because: -// - on Arm stack allocating MacroAssembler takes 120K bytes. -// See issue crbug.com/405338 -// - on Arm64 when running in single-process mode for Android WebView, when -// initializing V8 we already have a large stack and so have to set the -// limit lower. See issue crbug.com/v8/10575 -#define V8_DEFAULT_STACK_SIZE_KB 864 +#if 0 #elif V8_TARGET_ARCH_IA32 // In mid-2022, we're observing an increase in stack overflow crashes on // 32-bit Windows; the suspicion is that some third-party software suddenly
-- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
