On 31/03/2012 03:18, Jonas Smedegaard wrote: > Hi (mostly) Jérémy, > > You asked me on IRC to review libv8-i18n, and I now found time to do > so: > > Copyright file lacks Upstream-Source URL(s) and Upstream-Contact > address(es).
"Source" field. Done. > Copyright file lacks a Comment: referencing actual Apache 2.0 license > below /usr/share/common-licenses. Done. > Patch 2002 changes to include "v8.h" - but if that's system shared > header I suspect that should instead be <v8.h>. Done. > Seems irrelevant to me to mention origin or reverse dependencies in > long description: I suggest dropping 2nd paragraph. > > Makes more sense to me to first introduce what libv8 is and then that > this package is an extension to it: I suggest swapping those two > paragraphs in long description. OK. I was trying to explain that libv8-i18n is mainly needed by chromium, do you think it's still important to mention it ? > Please use anonvcs.debian.org URL in Vcs-Browser field. anonscm.debian.org Done. > I recommend using d-shlibs to handle installation of library files > and resolve library-related dependencies. All right - i'm not sure it's properly setup now. > I suggest re-wrapping control file long descriptions and copyright > file License fields at 72 chars (not 80 chars). Done. And favorite editor configured once and for all so that won't happen again :) > Did you consider using symbols file to track API/ABI changes instead > of simply relying on upstream version for that? Especially since > you really do not use upstream releases but VCS snapshots: Seems > unlikely to me that SONAME should be bumped exactly when upstream > bumps version number, rather than such changes appearing at some > earlier VCS commit. After our discussion on #debian-js : libv8-i18n doesn't have upstream version nor upstream soname. Choosing for upstream version : 0~0.svn7 Choosing for soname : 0.0.0 Library version : $(soname).0.0 Hence full lib version will be 0.0.0.0.0 > Would be good if you could have get-orig-source target include a rule > to generate a Changelog.svn file, e.g. using > /usr/share/doc/subversion/examples/gnuify-changelog.pl.gz (but since > it is forbidden to rely on /usr/share/doc to exist, that script > should then be included in debian/ subdir). Great. I took the upstream copy - relicensed under Apache-2. Jérémy. _______________________________________________ Pkg-javascript-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
