Hi François-Régis 2014-03-20 18:32 GMT+01:00 François-Régis <frv-deb...@miradou.com>: > Hi everybody, > > Following Emilien and Marcelo reviews, I've restart the repo from > scratch and included their remarks, so if someone could have a look at > http://anonscm.debian.org/gitweb/?p=pkg-javascript/jquery-coolfieldset.git > and if ok upload it to unstable ?
Thanks for processing Marcelo and my comments. Regarding the minifying, I pointed you towards building inside a temporary debian/build folder. Marcelo reviewed my jquery-lazyload package, and his comment was that it's not necessary. He recommends just building inside the root directory, and then clean up [0]. I still think it's best not to mess directly in the root directory, so I've changed my package with an intermediary solution: building inside the debian/directory. That makes it a bit simpler (no need to mkdir the debian/build directory), but still keeps the packaging operations out of the root directory. See my changes [1]. I'm not saying you need to change your package, this is just meant as informative. Regarding the removal of the minified files: that is done to comply with the DFSG, as minified files are assimilated to compiled objects, not source code. As Debian requires the source to be provided, not the compiled binaries, the minified files must be removed fromt the upstream tarball. But that also means you must repackage the tarball, and you need to indicate -dfsg in the package version. I don't think you've taken these steps yet (and I need to do it as well for jquery-lazyload). See Marcelo's example [2]. Let us know if this is unclear. +Emilien [0] http://lists.alioth.debian.org/pipermail/pkg-javascript-devel/2014-March/007176.html [1] http://anonscm.debian.org/gitweb/?p=pkg-javascript/jquery-lazyload.git;a=commitdiff;h=1c65e8ddbf865c4c675fcc92148a334e3811146b [2] http://tinyurl.com/okmsdkt _______________________________________________ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
