On Fri, Oct 17, 2014 at 3:40 PM, Jérémy Lal <kapo...@melix.org> wrote:
> Le vendredi 17 octobre 2014 à 15:04 -0700, Andrew Kelley a écrit : > > On Fri, Oct 17, 2014 at 12:15 AM, Jérémy Lal <kapo...@melix.org> wrote: > > > > > Le jeudi 16 octobre 2014 à 14:17 -0700, Andrew Kelley a écrit : > > > > On Wed, Oct 15, 2014 at 12:44 AM, Jérémy Lal <kapo...@melix.org> > wrote: > > > > > > > > > > What should I do? > > > > > > > > > > Since both have same API, i'd add your patches as quilt patches to > > > > > node-findit that is already in debian and add a binary package > > > > > node-findit2 (symlinking /usr/lib/nodejs/findit to findit2). > > > > > > > > > > Or the reverse, change upstream and add binary node-findit to > > > > > node-findit2. > > > > > > > > > > > > What about this? > > > > > > > > * Add patch as quilt patch to node-findit that is already in debian > > > > * When packaging other package updates that depend on findit2, patch > them > > > > to depend on node-findit instead, since the patch provides the > findit2 > > > API > > > > and bug fixes. > > > > > > I agree up to that point where you imply that findit2 has a different > > > API ? If that's the case then findit2 must be... findit2 ! > > > > > > > Hmm, in this case, since upstream seems to be ignoring my pull request, > > maybe I will > > > > * rename the module to a better fork name (as I did with formidable -> > > multiparty) > > * add new node module to debian > > * update packages to depend on new module > > * delete node-findit from debian since nothing depends on it > > If that's the case, then please keep a name close to the original one, > so that when packaging a module depending on (old) findit, one can find > easily the new findit to be a match. > > You might also want to commit to keep a backward-compatible API with > node-findit. > > These are only suggestions. I have thought about it, and I decided to keep the name as findit2. Also I agree to commit to backward-compatible API with node-findit, so that debian packages can use findit2 instead. I should have a package done here shortly. One thing that is kind of funny, is that since I cleaned up the code considerably, the lines of code is now small enough that FTP masters might say it is too small!! But hopefully if we tell them we are going to remove node-findit and this package is intended to replace it, then they will be OK with it.