Your message dated Sun, 26 Apr 2015 08:29:40 +0000
with message-id <[email protected]>
and subject line Bug#759673: fixed in libuv 0.10.36-1
has caused the Debian Bug report #759673,
regarding Patch to fix libuv on the hppa architecture (value of O_NONBLOCK 
possibly different than SOCK_NONBLOCK)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
759673: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=759673
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libuv-dev
Version: 0.10.28-3
Severity: normal
Tags: patch

Building on the hppa/parisc arch fails, because libuv fails to run sucessfully 
quite some integrated tests as can be seen in this log:
http://buildd.debian-ports.org/status/fetch.php?pkg=libuv&arch=hppa&ver=0.10.28-3&stamp=1409185348

I invested some time to find the reason why it fails, and it turned out that it 
happens because there is an
assumption in the libuv linux-syscalls.h header file, that on all Linux 
platforms the value of O_NONBLOCK is the same as SOCK_NONBLOCK.
That's at least not true for hppa.

In src/unix/linux-syscalls.h we have for hppa:
# define UV__O_NONBLOCK       0x10004  (hppa)
and later down:
#define UV__SOCK_NONBLOCK     UV__O_NONBLOCK

This means, libuv uses even for socket syscalls UV__O_NONBLOCK instead of the 
value of SOCK_NONBLOCK.
So, when the tests run, the kernel will correctly return -EINVAL on most socket 
syscalls and thus the libuv testcases fail.

The attached trivial patch fixes this problem on the hppa platform and it 
should be safe to use it for all other platforms too.

It would be great if you could apply it to the next upload of libuv.

Thanks,
Helge
diff -up ./src/unix/linux-syscalls.h.org ./src/unix/linux-syscalls.h
--- ./src/unix/linux-syscalls.h.org	2014-08-29 11:07:57.439621858 +0200
+++ ./src/unix/linux-syscalls.h	2014-08-29 11:22:24.050133474 +0200
@@ -43,7 +43,7 @@
 #if defined(__alpha__)
 # define UV__O_NONBLOCK       0x4
 #elif defined(__hppa__)
-# define UV__O_NONBLOCK       0x10004
+# define UV__O_NONBLOCK       O_NONBLOCK
 #elif defined(__mips__)
 # define UV__O_NONBLOCK       0x80
 #elif defined(__sparc__)
@@ -59,7 +59,11 @@
 #define UV__IN_NONBLOCK       UV__O_NONBLOCK
 
 #define UV__SOCK_CLOEXEC      UV__O_CLOEXEC
-#define UV__SOCK_NONBLOCK     UV__O_NONBLOCK
+#if defined(SOCK_NONBLOCK)
+# define UV__SOCK_NONBLOCK    SOCK_NONBLOCK
+#else
+# define UV__SOCK_NONBLOCK    UV__O_NONBLOCK
+#endif
 
 /* epoll flags */
 #define UV__EPOLL_CLOEXEC     UV__O_CLOEXEC

--- End Message ---
--- Begin Message ---
Source: libuv
Source-Version: 0.10.36-1

We believe that the bug you reported is fixed in the latest version of
libuv, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Luca Bruno <[email protected]> (supplier of updated libuv package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 25 Apr 2015 19:19:34 +0200
Source: libuv
Binary: libuv0.10-dev libuv0.10 libuv0.10-dbg
Architecture: source
Version: 0.10.36-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers 
<[email protected]>
Changed-By: Luca Bruno <[email protected]>
Description:
 libuv0.10  - asynchronous event notification library - runtime library
 libuv0.10-dbg - asynchronous event notification library - debugging symbols
 libuv0.10-dev - asynchronous event notification library - development files
Closes: 759673 773341
Changes:
 libuv (0.10.36-1) unstable; urgency=medium
 .
   * New upstream version
     + Refresh patches and drop applied upstream ones
     + Fix O_NONBLOCK handling (Closes: #759673)
     + Fix underlinking issues against phtread (Closes: #773341)
   * Update metadata after github project move
   * gbp: update config for new repository
Checksums-Sha1:
 50b3bb3ad040fe776d7ae6646a6521a1734b4186 2059 libuv_0.10.36-1.dsc
 0991836d1dbf9419f448bc3459559181505e29c5 335090 libuv_0.10.36.orig.tar.gz
 ecc8f326e15fb11f6bc21c05e8bc9ee064c38227 6928 libuv_0.10.36-1.debian.tar.xz
Checksums-Sha256:
 6b33ae8f6a5d3221b95b7dd6607eb9115a5b7b9a15c4c429601c92d647a010bd 2059 
libuv_0.10.36-1.dsc
 421087044cab642f038c190f180d96d6a1157be89adb4630881930495b8f5228 335090 
libuv_0.10.36.orig.tar.gz
 634037289795586a48776d0e0b7ada2246defcb690256f84fb4dfec19b7572e7 6928 
libuv_0.10.36-1.debian.tar.xz
Files:
 f23da30893ce614e2363263544f59594 2059 libs optional libuv_0.10.36-1.dsc
 8e5056c7b4d721d87fb1f8fcf115fae5 335090 libs optional libuv_0.10.36.orig.tar.gz
 84649df52e9116daa3e5236615c78651 6928 libs optional 
libuv_0.10.36-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVO9FMAAoJEKmDSiJSB45OllAQAL2ZwmX8tiYSp1U1WhRgdtL9
RJLYCBhTaInQw7BiW5IMy9o9zcxCEsBPbZnzMFe7Ws4lRg1ItvBONuyYLYCO0s+J
dHOY0hjjce90JMzXQTOWVgTH31D11ZsLl0GUypapQCLk5V8rr/onaPuRFzspyGax
lFzI3/v0MHWPrfUumN7qeTTO2a4zS26zW5BEOQJhALRSEwOhzaVDLkjWCJoNDBXi
WYEXds3ukjZphJ2xyIPRyJOWpyHIl9pF5q7c27Ruj0zZAy7vSZsW/cHxsGv2x4Ja
867TXMuc/0vyhleyhlgYIEqZLDFMBiWI1fk6Rf9oCyAIfMnVEDR0PI1KNy58Yvy1
Um24pDF97sczJCZKvbg4f1S4YBgfGFRFiID0Q1FExlRPF8DMqo1By14a+G2lSNjm
w9hURdyDmkg8uLIch0aXFpuS1GDgGPREOJJFuPvkurbJw0+aZNdUpUHo4E63AJyp
l/VLFzoC3owUMH8xTKjIOW592ZJKv6Ctfil+NmyrqpNQ7XsHQweIaNfgVVfHBMEt
nCiISyziej3d5YKeuvcsGwXeTG6niK8Q7Bze8WUO/U37eCehWIHpH5BvqEh+XZ+i
62BJIlvF5vVnl9x355IGGCEKsjgbyw3iMSvIyKIVYpHcJP6rhQgScEoVoA54X14Z
yJ63YUuOI6PuNhaH3oaI
=0WGZ
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
Pkg-javascript-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Reply via email to