On 06-Apr-2017, Philipp Hahn wrote:

> today I spent some time on investigating this issue

Thank you!

> <https://github.com/tzuryby/jquery.hotkeys/commit/321e02b98be973d1ea09eb97ceb921411ffb3415>
> introduced an incompatible ABI change how events are registered:

So the <URL:https://github.com/jeresig/jquery.hotkeys> and the
<URL:https://github.com/tzuryby/jquery.hotkeys> repositories have
diverged, incompatibly. I didn't know that :-/

> So "coverage_html.js" uses the 'jeresig' API to pass the hotkey via
> "data", while the 'tzuryby' API "jquery.hotkeys.js" expects is via
> 'namespace'.

That's good investigation, thank you for that.

> libjs-jquery-hotkeys currently is used by 3 packages in Debian:
> - libghc-gitit-data
> - prometheus
> - python-pytest-cov

I count 6 binary packages:

=====
$ apt-cache rdepends libjs-jquery-hotkeys
libjs-jquery-hotkeys
Reverse Depends:
  libghc-gitit-data
  python3-pytest-cov
  python-pytest-cov
  python3-coverage
  python-coverage
  prometheus
=====

The source packages are:

* gitit
* python-coverage
* python-pytest-cov
* prometheus

Why are we getting different sets of packages that use
‘libjs-jquery-hotkeys’?

> Doing some source code `grep -n -r "[.]bind([\"']key"`:

When I use the pattern ‘[.]bind\(["']key’ for each of those source
packages with <URL:https://codesearch.debian.net/>, I get a different
set.

These queries show matches:

<URL:https://codesearch.debian.net/search?q=[.]bind\%28[%22%27]key+package%3Agitit>
<URL:https://codesearch.debian.net/search?q=[.]bind\%28[%22%27]key+package%3Apython-coverage>
<URL:https://codesearch.debian.net/search?q=[.]bind\%28[%22%27]key+package%3Aprometheus>

This does not:

<URL:https://codesearch.debian.net/search?q=[.]bind\%28[%22%27]key+package%3Apython-pytest-cov>

Does that mean ‘python-pytest-cov’ is not using the ‘jeresig’ API?

Is there a better regex pattern to use to determine what API is used?

> So all of them use the "jeresig" API, but 'libjs-jquery-hotkeys'
> packages the "tzuryby" API.

We get differing results, so I'd like to better understand before
choosing how to resolve this.

-- 
 \      “How many people here have telekenetic powers? Raise my hand.” |
  `\                                                      —Emo Philips |
_o__)                                                                  |
Ben Finney <bign...@debian.org>

Attachment: signature.asc
Description: PGP signature

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Reply via email to