David,

First of all, thank you for your work on the package.

Some quick comments:

On Mon, Jun 02, 2008 at 04:34:32PM +0200, David Paleino wrote:
>     - added support for Microsoft Windows NT/2000/XP/2003 NTLM (MD4) hash
>       (patch by Alain Espinosa <[EMAIL PROTECTED]>)
>     - added support for Windows 2000/XP/2003 credentials cache hash (patch
>       by Alain Espinosa <[EMAIL PROTECTED]>)

These are rather good, so it should be OK.

>     - added support for LM/NTLMv1 challenge/response (ported from 1.7.0.2)
>       (patch by by JoMo-Kun <[EMAIL PROTECTED]>)

This one is also relatively clean, but it introduces a dependency on
OpenSSL.  This is JFYI.

Also, doesn't Debian have a policy on obfuscating e-mail addresses?  If
not, then it should!  I surely would not want my e-mail address added to
Debian changelogs non-obfuscated.

>     - added Build-Depends on libssl-dev

Ah, OK, so you know it.

>     - conditionally add -funroll-loops on !arm machines

What's the deal with this?  Is it anything I could want to fix upstream?

Alexander

-- 
Pkg-john-devel mailing list
Pkg-john-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-john-devel

Reply via email to