On Mon, 2 Jun 2008 18:41:25 +0400, Solar Designer wrote:

> David,

Hi Alex,

> First of all, thank you for your work on the package.

:)

> On Mon, Jun 02, 2008 at 04:34:32PM +0200, David Paleino wrote:
> >     - added support for Microsoft Windows NT/2000/XP/2003 NTLM (MD4) hash
> >       (patch by Alain Espinosa <[EMAIL PROTECTED]>)
> >     - added support for Windows 2000/XP/2003 credentials cache hash (patch
> >       by Alain Espinosa <[EMAIL PROTECTED]>)  
> 
> These are rather good, so it should be OK.

Is there any other patch you would recommend? I'll add them in future revisions.

> Also, doesn't Debian have a policy on obfuscating e-mail addresses?  If
> not, then it should!  I surely would not want my e-mail address added to
> Debian changelogs non-obfuscated.

Not really -- I'm doing some simple obfuscation now, thanks for the remark.

> >     - conditionally add -funroll-loops on !arm machines
> 
> What's the deal with this?  Is it anything I could want to fix upstream?

No.
It's a gcc-4.3 bug, which is going to be solved soon on arm (aprox. next week).
But I'm currently in a hurry -- I really want the new john to enter Lenny. So I
just patched your src/Makefile:

===8<===
--- john.orig/src/Makefile
+++ john/src/Makefile
@@ -18,7 +18,11 @@
 CFLAGS = -c -Wall -O2 -fomit-frame-pointer
 ASFLAGS = -c
 LDFLAGS = -s
-OPT_NORMAL = -funroll-loops
+
+# -funroll-loops set in debian/rules, for failed build on ARM.
+# Please see #476460
+#OPT_NORMAL = -funroll-loops
+OPT_NORMAL =
 OPT_INLINE = -finline-functions
 
 JOHN_OBJS_MINIMAL = \
===>8===

And added this to our debian/rules:

CPU   := $(shell dpkg-architecture -qDEB_HOST_ARCH_CPU)
[..]
# GCC segfaults on ARM if -funroll-loops is used.
# Please see #476460
ifneq ($(CPU),arm)
        CFLAGS += -funroll-loops
endif

That should do the trick, for the moment.

Thanks to this quick review, I've just found that I've released the .deb with
that CPU:=... line commented out.

For sponsors: a user just filed a bug which I already addressed (#484109), so I
just added the number to the previous changelog.
Please pick the .dsc again from mentors:

<http://mentors.debian.net/debian/pool/main/j/john/john_1.7.2-3.dsc>

Kindly,
David

-- 
 . ''`.  Debian maintainer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://snipr.com/qa_page
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

Attachment: signature.asc
Description: PGP signature

-- 
Pkg-john-devel mailing list
Pkg-john-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-john-devel

Reply via email to