Hello,
apart from the "Real Name"/"Copyright Holder" issue, I'm missing a copyright
statement for src/rawSHA1_fmt.c .
Please choose a DFSG-free license, and also keep an eye on [0] if you want your
module be included in JtR upstream.

[0]
http://lists.alioth.debian.org/pipermail/pkg-john-devel/2009-January/000232.html

Also, src/sha.h is missing both a copyright statement and an author/copyright
holder. You're not listed there, but this file seems coming from the same patch
as src/rawSHA1_fmt.c. Do you know how can I contact its author? (or is it you?)

Kindly,
David

-- 
 . ''`.  Debian maintainer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://snipr.com/qa_page
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

Attachment: signature.asc
Description: PGP signature

-- 
Pkg-john-devel mailing list
Pkg-john-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-john-devel

Reply via email to