Your message dated Fri, 27 Nov 2009 15:54:27 +0000
with message-id <e1ne39p-0006dn...@ries.debian.org>
and subject line Bug#549221: fixed in k3b 1.69.0~alpha4-1
has caused the Debian Bug report #549221,
regarding [PATCH] Updated patch for K3B - normalize audio detection
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
549221: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=549221
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: k3b
Version: 1.66.0~alpha2-1

With the patch currently included with this version of K3B, normalize-audio 
detection does not work properly (at least tested under current Kubuntu 9.10 
Beta and I assume same would apply for Debian Experimental). 

I have updated the patch to fully rename all references to normalize to 
normalize-audio, including the kconfig read/write sections. Although these may 
not be strictly required, it does make for a more accurate conversion.

As well, I have manually set the version detection to look for 'normalize' and 
not the default which is the program name set (i.e. 'normalize-audio'). As you 
can see below, the normalize package reports the following via the version 
command:

rgreen...@atlantis:~/Source/ninjas/karmic/k3b$ normalize-audio -V
normalize 0.7.7
Copyright (C) 2005 Chris Vaill
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
This copy of normalize is compiled with the following libraries:
  MAD  audiofile

The fix is to add this line to the normalize detection, to force it to look for 
normalize and not normalize-audio:

setVersionIdentifier( QLatin1String( "normalize" ) );

This patch has been tested under Kubuntu 9.10 Beta, and was verified to work as 
expected with no noticeable side effects.

Regards,

Rod.
_______________________________________
Roderick B. Greening, B.Sc.
Paradise, NL Canada
E-mail/MSN: roderick.green...@gmail.com 
LP: launchpad.net/~roderick-greening 
Wiki: wiki.ubuntu.com/rgreening 
Blog: roderick-greening.blogspot.com 
Twitter: twitter.com/rgreening
Identica: identi.ca/rgreening
Description: normalize is named "normalize-audio" in Debian.
 Change that everywhere.... for real this time
Reviewed-by: Didier Raboud <did...@raboud.com>
Updated-by: Roderick B. Greening <roderick.green...@gmail.com>
Last-Update: 2009-09-30

--- a/libk3b/core/k3bdefaultexternalprograms.cpp
+++ b/libk3b/core/k3bdefaultexternalprograms.cpp
@@ -388,8 +388,9 @@ K3b::VcdbuilderProgram::VcdbuilderProgra
 
 
 K3b::NormalizeProgram::NormalizeProgram()
-    : K3b::SimpleExternalProgram( "normalize" )
+    : K3b::SimpleExternalProgram( "normalize-audio" )
 {
+    setVersionIdentifier( QLatin1String( "normalize" ) );
 }
 

--- a/libk3b/projects/audiocd/k3baudiodoc.cpp
+++ b/libk3b/projects/audiocd/k3baudiodoc.cpp
@@ -524,7 +524,7 @@
                 return false;
         }
 
-        else if( e.nodeName() == "normalize" )
+        else if( e.nodeName() == "normalize-audio" )
             setNormalize( e.text() == "yes" );
 
         else if( e.nodeName() == "hide_first_track" )
@@ -728,7 +728,7 @@
     saveGeneralDocumentData( docElem );
 
     // add normalize
-    QDomElement normalizeElem = doc.createElement( "normalize" );
+    QDomElement normalizeElem = doc.createElement( "normalize-audio" );
     normalizeElem.appendChild( doc.createTextNode( normalize() ? "yes" : "no" ) );
     docElem->appendChild( normalizeElem );
 
--- a/libk3b/projects/audiocd/k3baudionormalizejob.cpp
+++ b/libk3b/projects/audiocd/k3baudionormalizejob.cpp
@@ -50,10 +50,10 @@ void K3b::AudioNormalizeJob::start()
     connect( m_process, SIGNAL(stderrLine(const QString&)), this, SLOT(slotStdLine(const QString&)) );
     connect( m_process, SIGNAL(finished(int, QProcess::ExitStatus)), this, SLOT(slotProcessExited(int, QProcess::ExitStatus)) );
 
-    const K3b::ExternalBin* bin = k3bcore->externalBinManager()->binObject( "normalize" );
+    const K3b::ExternalBin* bin = k3bcore->externalBinManager()->binObject( "normalize-audio" );
 
     if( !bin ) {
-        emit infoMessage( i18n("Could not find normalize executable."), MessageError );
+        emit infoMessage( i18n("Could not find normalize-audio executable."), MessageError );
         jobFinished(false);
         return;
     }
@@ -80,8 +80,8 @@ void K3b::AudioNormalizeJob::start()
     if( !m_process->start( KProcess::OnlyStderrChannel ) ) {
         // something went wrong when starting the program
         // it "should" be the executable
-        kDebug() << "(K3b::AudioNormalizeJob) could not start normalize";
-        emit infoMessage( i18n("Could not start normalize."), K3b::Job::MessageError );
+        kDebug() << "(K3b::AudioNormalizeJob) could not start normalize-audio";
+        emit infoMessage( i18n("Could not start normalize-audio."), K3b::Job::MessageError );
         jobFinished(false);
     }
 }
@@ -104,7 +104,7 @@ void K3b::AudioNormalizeJob::slotStdLine
 
     //  emit newSubTask( i18n("Normalizing track %1 of %2 (%3)",t,tt,m_files.at(t-1)) );
 
-    emit debuggingOutput( "normalize", line );
+    emit debuggingOutput( "normalize-audio", line );
 
     // wenn "% done" drin:
     //    wenn ein --% drin ist, so beginnt ein neuer track
@@ -183,7 +183,7 @@ void K3b::AudioNormalizeJob::slotProcess
             break;
         default:
             if( !m_canceled ) {
-                emit infoMessage( i18n("%1 returned an unknown error (code %2).",QString("normalize"), exitCode),
+                emit infoMessage( i18n("%1 returned an unknown error (code %2).",QString("normalize-audio"), exitCode),
                                   K3b::Job::MessageError );
                 emit infoMessage( i18n("Please send me an email with the last output."), K3b::Job::MessageError );
                 emit infoMessage( i18n("Error while normalizing tracks."), MessageError );
--- a/src/k3bprojectmanager.cpp
+++ b/src/k3bprojectmanager.cpp
@@ -293,7 +293,7 @@
 
         audioDoc->writeCdText( c.readEntry( "cd_text", true ) );
         audioDoc->setHideFirstTrack( c.readEntry( "hide_first_track", false ) );
-        audioDoc->setNormalize( c.readEntry( "normalize", false ) );
+        audioDoc->setNormalize( c.readEntry( "normalize-audio", false ) );
         audioDoc->setAudioRippingParanoiaMode( c.readEntry( "paranoia mode", 0 ) );
         audioDoc->setAudioRippingRetries( c.readEntry( "read retries", 128 ) );
         audioDoc->setAudioRippingIgnoreReadErrors( c.readEntry( "ignore read errors", false ) );
@@ -364,7 +364,7 @@
         K3b::MixedDoc* mixedDoc = static_cast<K3b::MixedDoc*>(doc);
 
         mixedDoc->audioDoc()->writeCdText( c.readEntry( "cd_text", true ) );
-        mixedDoc->audioDoc()->setNormalize( c.readEntry( "normalize", false ) );
+        mixedDoc->audioDoc()->setNormalize( c.readEntry( "normalize-audio", false ) );
 
         // load mixed type
         if( c.readEntry( "mixed_type" ) == "last_track" )
--- a/src/projects/k3baudioburndialog.cpp
+++ b/src/projects/k3baudioburndialog.cpp
@@ -186,7 +186,7 @@
 
     m_cdtextWidget->setChecked( c.readEntry( "cd_text", true ) );
     m_checkHideFirstTrack->setChecked( c.readEntry( "hide_first_track", false ) );
-    m_checkNormalize->setChecked( c.readEntry( "normalize", false ) );
+    m_checkNormalize->setChecked( c.readEntry( "normalize-audio", false ) );
 
     m_comboParanoiaMode->setCurrentIndex( c.readEntry( "paranoia mode", 0 ) );
     m_checkAudioRippingIgnoreReadErrors->setChecked( c.readEntry( "ignore read errors", true ) );
@@ -202,7 +202,7 @@
 
     c.writeEntry( "cd_text", m_cdtextWidget->isChecked() );
     c.writeEntry( "hide_first_track", m_checkHideFirstTrack->isChecked() );
-    c.writeEntry( "normalize", m_checkNormalize->isChecked() );
+    c.writeEntry( "normalize-audio", m_checkNormalize->isChecked() );
 
     c.writeEntry( "paranoia mode", m_comboParanoiaMode->currentText() );
     c.writeEntry( "ignore read errors", m_checkAudioRippingIgnoreReadErrors->isChecked() );
@@ -283,11 +283,11 @@ void K3b::AudioBurnDialog::slotNormalize
 {
     if( on ) {
         // we are not able to normalize in on-the-fly mode
-        if( !k3bcore->externalBinManager()->foundBin( "normalize" ) ) {
-            KMessageBox::sorry( this, i18n("<p><b>External program <em>normalize</em> is not installed.</b>"
-                                           "<p>K3b uses <em>normalize</em> (http://normalize.nongnu.org/) "
+        if( !k3bcore->externalBinManager()->foundBin( "normalize-audio" ) ) {
+            KMessageBox::sorry( this, i18n("<p><b>External program <em>normalize-audio</em> is not installed.</b>"
+                                           "<p>K3b uses <em>normalize-audio</em> (http://normalize.nongnu.org/) "
                                            "to normalize audio tracks. In order to "
-                                           "use this functionality, please install it first.") );
+                                           "use this functionality, please install it first. (sudo apt-get install normalize-audio) " ) );
             m_checkNormalize->setChecked( false );
         }
         else if( !m_checkCacheImage->isChecked() && !m_checkOnlyCreateImage->isChecked() ) {
--- a/src/projects/k3bmixedburndialog.cpp
+++ b/src/projects/k3bmixedburndialog.cpp
@@ -201,7 +201,7 @@
     K3b::ProjectBurnDialog::loadSettings( c );
 
     m_cdtextWidget->setChecked( c.readEntry( "cd_text", false ) );
-    m_checkNormalize->setChecked( c.readEntry( "normalize", false ) );
+    m_checkNormalize->setChecked( c.readEntry( "normalize-audio", false ) );
 
     // load mixed type
     if( c.readEntry( "mixed_type" ) == "last_track" )
@@ -225,7 +225,7 @@
     K3b::ProjectBurnDialog::saveSettings(c);
 
     c.writeEntry( "cd_text", m_cdtextWidget->isChecked() );
-    c.writeEntry( "normalize", m_checkNormalize->isChecked() );
+    c.writeEntry( "normalize-audio", m_checkNormalize->isChecked() );
 
     // save mixed type
     switch( m_comboMixedModeType->selectedValue() ) {
@@ -289,11 +289,11 @@ void K3b::MixedBurnDialog::slotNormalize
 {
     if( on ) {
         // we are not able to normalize in on-the-fly mode
-        if( !k3bcore->externalBinManager()->foundBin( "normalize" ) ) {
-            KMessageBox::sorry( this, i18n("<p><b>External program <em>normalize</em> is not installed.</b>"
-                                           "<p>K3b uses <em>normalize</em> (http://normalize.nongnu.org/) "
+        if( !k3bcore->externalBinManager()->foundBin( "normalize-audio" ) ) {
+            KMessageBox::sorry( this, i18n("<p><b>External program <em>normalize-audio</em> is not installed.</b>"
+                                           "<p>K3b uses <em>normalize-audio</em> (http://normalize.nongnu.org/) "
                                            "to normalize audio tracks. In order to "
-                                           "use this functionality, please install it first.") );
+                                           "use this functionality, please install it first (sudo apt-get install normalize-audio).") );
             m_checkNormalize->setChecked( false );
         }
         else if( !m_checkCacheImage->isChecked() && !m_checkOnlyCreateImage->isChecked() ) {

Attachment: signature.asc
Description: This is a digitally signed message part.


--- End Message ---
--- Begin Message ---
Source: k3b
Source-Version: 1.69.0~alpha4-1

We believe that the bug you reported is fixed in the latest version of
k3b, which is due to be installed in the Debian FTP archive:

k3b-data_1.69.0~alpha4-1_all.deb
  to main/k/k3b/k3b-data_1.69.0~alpha4-1_all.deb
k3b-dbg_1.69.0~alpha4-1_amd64.deb
  to main/k/k3b/k3b-dbg_1.69.0~alpha4-1_amd64.deb
k3b_1.69.0~alpha4-1.diff.gz
  to main/k/k3b/k3b_1.69.0~alpha4-1.diff.gz
k3b_1.69.0~alpha4-1.dsc
  to main/k/k3b/k3b_1.69.0~alpha4-1.dsc
k3b_1.69.0~alpha4-1_amd64.deb
  to main/k/k3b/k3b_1.69.0~alpha4-1_amd64.deb
k3b_1.69.0~alpha4.orig.tar.gz
  to main/k/k3b/k3b_1.69.0~alpha4.orig.tar.gz
libk3b-dev_1.69.0~alpha4-1_amd64.deb
  to main/k/k3b/libk3b-dev_1.69.0~alpha4-1_amd64.deb
libk3b6-extracodecs_1.69.0~alpha4-1_amd64.deb
  to main/k/k3b/libk3b6-extracodecs_1.69.0~alpha4-1_amd64.deb
libk3b6_1.69.0~alpha4-1_amd64.deb
  to main/k/k3b/libk3b6_1.69.0~alpha4-1_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 549...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Meskes <mes...@debian.org> (supplier of updated k3b package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 27 Nov 2009 15:16:28 +0100
Source: k3b
Binary: k3b k3b-data libk3b-dev libk3b6 libk3b6-extracodecs k3b-dbg
Architecture: source amd64 all
Version: 1.69.0~alpha4-1
Distribution: experimental
Urgency: low
Maintainer: Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>
Changed-By: Michael Meskes <mes...@debian.org>
Description: 
 k3b        - A sophisticated CD/DVD burning application
 k3b-data   - A sophisticated CD/DVD burning application - data files
 k3b-dbg    - A sophisticated CD/DVD burning application - debugging symbols
 libk3b-dev - The KDE CD/DVD burning application library - development files
 libk3b6    - The KDE CD/DVD burning application library - runtime files
 libk3b6-extracodecs - The KDE CD/DVD burning application library - extra 
decoders
Closes: 549221
Changes: 
 k3b (1.69.0~alpha4-1) experimental; urgency=low
 .
   [ Fathi Boudra ]
   * New upstream release.
     - Remove 107_iso_cue_mimetypes.diff - Merged upstream.
     - Remove 114_new_libmpcdec_api.diff - Merged upstream.
 .
   [ Michael Meskes ]
   * Updated normalize-audio patch to make sure the program is correctly
     recognized. Thanks to Roderick B. Greening. (Closes: #549221)
Checksums-Sha1: 
 dcae1d034fb1196b4a7dcd800dfbb4ac9e9f7dfa 1612 k3b_1.69.0~alpha4-1.dsc
 189e3454bc1410a0cdcc0f39fe308a0c7cda8d91 5085393 k3b_1.69.0~alpha4.orig.tar.gz
 f272d6bd5908557968f8bb41dae85f8b08f13f4a 23705 k3b_1.69.0~alpha4-1.diff.gz
 67f65c23707c1140fb560cce2dec325251e1ab5e 774086 k3b_1.69.0~alpha4-1_amd64.deb
 6e273c474018c92548ff4ff9fa8d0835d636d64b 3824286 
k3b-data_1.69.0~alpha4-1_all.deb
 eb7dd0286086b394805a6117894199217cbfa04f 124804 
libk3b-dev_1.69.0~alpha4-1_amd64.deb
 e01d329bf1585ea9c9e8ec89ab7a1ada5d976be0 1060428 
libk3b6_1.69.0~alpha4-1_amd64.deb
 ab86da7aefac04086fbf5b2da304ced66767da7e 68264 
libk3b6-extracodecs_1.69.0~alpha4-1_amd64.deb
 724b502f1cd12d13224d60b795f282c960bdec31 18406940 
k3b-dbg_1.69.0~alpha4-1_amd64.deb
Checksums-Sha256: 
 c91a174d6ef758bc627c1059c876ace4fe9860f254218e51d6c19a6f258e38af 1612 
k3b_1.69.0~alpha4-1.dsc
 7224ae9325ec191b02ae753a8ae1bef16df911f9c71170eaa5d4c91fb0c7e813 5085393 
k3b_1.69.0~alpha4.orig.tar.gz
 67dd8fb5252ef695a2163921ab024db492322764e30d952869574ed83930f7f9 23705 
k3b_1.69.0~alpha4-1.diff.gz
 527b56e0a9bdc970baf4694ca4f191ed944e6168c0ccdf81ae973e4db132532d 774086 
k3b_1.69.0~alpha4-1_amd64.deb
 dab84a9c9db23f9084cd50e8412788b82447a97aa77c8e6c4c645600f839a79c 3824286 
k3b-data_1.69.0~alpha4-1_all.deb
 b7a5f71af515ca4142ee1550e3bb3829a2fb57ebaf217645c5ee4075ea7c03c1 124804 
libk3b-dev_1.69.0~alpha4-1_amd64.deb
 0f5cc8efc0c7747fd8e9e4bdc39b31c5bdc938edb14a32cf28e2890e33917da4 1060428 
libk3b6_1.69.0~alpha4-1_amd64.deb
 f509f119ce196ab8eccd00f3a24a3c72dc2e9347108c992fc7011f20b48bc3da 68264 
libk3b6-extracodecs_1.69.0~alpha4-1_amd64.deb
 50f176d33cac98cf7854868c49411cf7791c438f0669fc431b88692c0b32b117 18406940 
k3b-dbg_1.69.0~alpha4-1_amd64.deb
Files: 
 f38a9cb8b0bfc3d31dd6bd47631fdb24 1612 utils optional k3b_1.69.0~alpha4-1.dsc
 495e577e5fe55a85d9ba150cc6316df1 5085393 utils optional 
k3b_1.69.0~alpha4.orig.tar.gz
 d85179dba83b31789ab77b54f252bb69 23705 utils optional 
k3b_1.69.0~alpha4-1.diff.gz
 6f9c09e2651df314320cd69b31f927c8 774086 utils optional 
k3b_1.69.0~alpha4-1_amd64.deb
 2800e41e420084b42d90fa7daa7ceb85 3824286 utils optional 
k3b-data_1.69.0~alpha4-1_all.deb
 21d092950169caaef08574f73be8f036 124804 libdevel optional 
libk3b-dev_1.69.0~alpha4-1_amd64.deb
 d622ce601f7106d61314a6cb1e2ffaf1 1060428 libs optional 
libk3b6_1.69.0~alpha4-1_amd64.deb
 fcb5ade85500f0fc4c8710dad0a795da 68264 libs optional 
libk3b6-extracodecs_1.69.0~alpha4-1_amd64.deb
 11e781e5ee0a785304ccb7ca86b8d3ae 18406940 debug extra 
k3b-dbg_1.69.0~alpha4-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLD+3fVkEm8inxm9ERArQxAJ9uvdQXSKOObP5nNRpq0KmZUU/9WACdHnlu
V1HdpJKiFtYkscPS1zEX+/A=
=32AW
-----END PGP SIGNATURE-----



--- End Message ---
_______________________________________________
pkg-kde-extras mailing list
pkg-kde-extras@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-kde-extras

Reply via email to