(Hereby ignoring the tone of your private ping)

Le mercredi, 16 mai 2012 23.23:02, Boris Pek a écrit :
> Great! Could you look on the package now?

Yeah. I took a look.

1) Versioning

So, what I wrote before about the version is not completely true: bumping the 
epoch is not _strictly_ needed as 2:0.5.3-1 from src:kcm-gtk would sort before 
an 2:2.0-1 from src:kde-gtk-config. That said, I think that bumping the epoch 
would be a clear indication that the source for this package changed so is not 
necessarily bad. I'll leave that decision up to you.

2) Handling of the transition

I just tested with a clean user: the current kde-config-gtk-style creates one 
.gtkrc-2.0-kde while your new kde-config-gtk-style creates one .gtkrc-2.0-kde4 
that is a symlink to .gtkrc-2.0 . You should probably cope with 
04_no_kde4_in_configfile.diff in src:kcm-gtk and make sure any changes put 
there by kcm-gtk is kept gracefully. As a general rule, make sure that any bug 
fixed in kcm-gtk (by its patches or by its code) is not re-introduced by 
src:kde-gtk-config.

Other than that, it looks fine but at least 2) ought to be fixed.

Cheers,

OdyX

_______________________________________________
pkg-kde-extras mailing list
pkg-kde-extras@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-extras

Reply via email to