Dear Team, I’m working on updating ktp-common-internals to the latest upstream version (19.12.1) among other reasons to fix FTBFS #949236.
I’m not very used to packaging or updating libraries and there are a couple of symbol changes that I feel I need to ask for some review / help. Some changes caught by dpkg-gensymbols are symbols removals or replacements and they look like they are backwards incompatible and would deserve an ABI bump. But upstream didn’t do that. Am I missing something ? I guess I cannot do a ABI bump on the Debian side only that would be incompatible with future upstream ABI bumps, so what should I do ? Rebuild reverse dependencies and get going ? Go ahead and impact the symbol changes without worrying because these changes don’t really matter ? The dpkg-gensymbols diff is in attachment, stripped down from a couple of symbol additions that are obviously OK and backwards compatible. Thanks, -- Aurélien
dh_makeshlibs '-Xusr/lib/libkdeinit5_*' dpkg-gensymbols: warning: some new symbols appeared in the symbols file: see diff output below dpkg-gensymbols: error: some symbols or patterns disappeared in the symbols file: see diff output below dpkg-gensymbols: warning: debian/libktpcommoninternals9/DEBIAN/symbols doesn't match completely debian/libktpcommoninternals9.symbols --- debian/libktpcommoninternals9.symbols (libktpcommoninternals9_19.12.1-1_amd64) +++ dpkg-gensymbolsETZKHD 2020-01-27 20:16:53.266451824 +0100 @@ -49,25 +49,34 @@ _ZN3KTp14ContactFactoryC2ERKN2Tp8FeaturesE@Base 15.04.2 _ZN3KTp14GlobalPresence11qt_metacallEN11QMetaObject4CallEiPPv@Base 15.04.2 _ZN3KTp14GlobalPresence11qt_metacastEPKc@Base 15.04.2 - _ZN3KTp14GlobalPresence11setPresenceENS0_22ConnectionPresenceTypeE7QString@Base 15.04.2 - _ZN3KTp14GlobalPresence11setPresenceERKNS_8PresenceE@Base 15.04.2 - _ZN3KTp14GlobalPresence14onAccountAddedERKN2Tp9SharedPtrINS1_7AccountEEE@Base 15.04.2 +#MISSING: 19.12.1-1# _ZN3KTp14GlobalPresence11setPresenceENS0_22ConnectionPresenceTypeE7QString@Base 15.04.2 + _ZN3KTp14GlobalPresence11setPresenceENS0_22ConnectionPresenceTypeE7QStringNS0_13PresenceClassE@Base 19.12.1-1 +#MISSING: 19.12.1-1# _ZN3KTp14GlobalPresence11setPresenceERKNS_8PresenceE@Base 15.04.2 + _ZN3KTp14GlobalPresence11setPresenceERKNS_8PresenceENS0_13PresenceClassE@Base 19.12.1-1 +#MISSING: 19.12.1-1# _ZN3KTp14GlobalPresence14onAccountAddedERKN2Tp9SharedPtrINS1_7AccountEEE@Base 15.04.2 _ZN3KTp14GlobalPresence16changingPresenceEb@Base 15.04.2 _ZN3KTp14GlobalPresence16staticMetaObjectE@Base 15.04.2 _ZN3KTp14GlobalPresence17addAccountManagerERKN2Tp9SharedPtrINS1_14AccountManagerEEE@Base 15.04.2 _ZN3KTp14GlobalPresence17setAccountManagerERKN2Tp9SharedPtrINS1_14AccountManagerEEE@Base 15.04.2 - _ZN3KTp14GlobalPresence18onChangingPresenceEv@Base 15.04.2 + _ZN3KTp14GlobalPresence18onChangingPresenceEb@Base 19.12.1-1 +#MISSING: 19.12.1-1# _ZN3KTp14GlobalPresence18onChangingPresenceEv@Base 15.04.2 _ZN3KTp14GlobalPresence19accountManagerReadyEv@Base 15.04.2 - _ZN3KTp14GlobalPresence19saveCurrentPresenceEv@Base 15.04.2 - _ZN3KTp14GlobalPresence20restoreSavedPresenceEv@Base 15.04.2 - _ZN3KTp14GlobalPresence21onAccountManagerReadyEPN2Tp16PendingOperationE@Base 15.04.2 +#MISSING: 19.12.1-1# _ZN3KTp14GlobalPresence19saveCurrentPresenceEv@Base 15.04.2 +#MISSING: 19.12.1-1# _ZN3KTp14GlobalPresence20restoreSavedPresenceEv@Base 15.04.2 +#MISSING: 19.12.1-1# _ZN3KTp14GlobalPresence21onAccountManagerReadyEPN2Tp16PendingOperationE@Base 15.04.2 _ZN3KTp14GlobalPresence22currentPresenceChangedERKNS_8PresenceE@Base 15.04.2 - _ZN3KTp14GlobalPresence22enabledAccountsChangedEv@Base 15.07.90 - _ZN3KTp14GlobalPresence23connectionStatusChangedEN2Tp16ConnectionStatusE@Base 15.04.2 - _ZN3KTp14GlobalPresence24onCurrentPresenceChangedEv@Base 15.04.2 + _ZN3KTp14GlobalPresence22enabledAccountsChangedEb@Base 19.12.1-1 +#MISSING: 19.12.1-1# _ZN3KTp14GlobalPresence22enabledAccountsChangedEv@Base 15.07.90 +#MISSING: 19.12.1-1# _ZN3KTp14GlobalPresence23connectionStatusChangedEN2Tp16ConnectionStatusE@Base 15.04.2 + _ZN3KTp14GlobalPresence23connectionStatusChangedENS0_16ConnectionStatusE@Base 19.12.1-1 + _ZN3KTp14GlobalPresence23onAccountEnabledChangedERKN2Tp9SharedPtrINS1_7AccountEEE@Base 19.12.1-1 + _ZN3KTp14GlobalPresence24onCurrentPresenceChangedERKN2Tp8PresenceE@Base 19.12.1-1 +#MISSING: 19.12.1-1# _ZN3KTp14GlobalPresence24onCurrentPresenceChangedEv@Base 15.04.2 _ZN3KTp14GlobalPresence24requestedPresenceChangedERKNS_8PresenceE@Base 15.04.2 - _ZN3KTp14GlobalPresence25onConnectionStatusChangedEv@Base 15.04.2 - _ZN3KTp14GlobalPresence26onRequestedPresenceChangedEv@Base 15.04.2 + _ZN3KTp14GlobalPresence25onConnectionStatusChangedEN2Tp16ConnectionStatusE@Base 19.12.1-1 +#MISSING: 19.12.1-1# _ZN3KTp14GlobalPresence25onConnectionStatusChangedEv@Base 15.04.2 + _ZN3KTp14GlobalPresence26onRequestedPresenceChangedERKN2Tp8PresenceE@Base 19.12.1-1 +#MISSING: 19.12.1-1# _ZN3KTp14GlobalPresence26onRequestedPresenceChangedEv@Base 15.04.2 _ZN3KTp14GlobalPresenceC1EP7QObject@Base 15.04.2 _ZN3KTp14GlobalPresenceC2EP7QObject@Base 15.04.2 _ZN3KTp14MessageContextC1ERKN2Tp9SharedPtrINS1_7AccountEEERKNS2_INS1_11TextChannelEEE@Base 15.04.2 dpkg-gensymbols: warning: some new symbols appeared in the symbols file: see diff output below dpkg-gensymbols: error: some symbols or patterns disappeared in the symbols file: see diff output below dpkg-gensymbols: warning: debian/libktpmodels9/DEBIAN/symbols doesn't match completely debian/libktpmodels9.symbols --- debian/libktpmodels9.symbols (libktpmodels9_19.12.1-1_amd64) +++ dpkg-gensymbolsJuhLG5 2020-01-27 20:16:53.886458243 +0100 @@ -33,7 +33,7 @@ _ZN3KTp13PresenceModel11modifyModelERKNS_8PresenceE@Base 17.08.1 _ZN3KTp13PresenceModel11qt_metacallEN11QMetaObject4CallEiPPv@Base 15.04.2 _ZN3KTp13PresenceModel11qt_metacastEPKc@Base 15.04.2 - _ZN3KTp13PresenceModel12countChangedEv@Base 15.04.2 +#MISSING: 19.12.1-1# _ZN3KTp13PresenceModel12countChangedEv@Base 15.04.2 _ZN3KTp13PresenceModel13loadPresencesEv@Base 15.04.2 _ZN3KTp13PresenceModel14removePresenceERKNS_8PresenceE@Base 15.04.2 _ZN3KTp13PresenceModel15propagateChangeERKNS_8PresenceE@Base 17.08.1 @@ -220,17 +220,19 @@ _ZNK3KTp13PresenceModel10metaObjectEv@Base 15.04.2 _ZNK3KTp13PresenceModel3getEiRK10QByteArray@Base 15.04.2 _ZNK3KTp13PresenceModel4dataERK11QModelIndexi@Base 15.04.2 - _ZNK3KTp13PresenceModel4dataEi@Base 15.04.2 +#MISSING: 19.12.1-1# _ZNK3KTp13PresenceModel4dataEi@Base 15.04.2 + _ZNK3KTp13PresenceModel5matchERK11QModelIndexiRK8QVarianti6QFlagsIN2Qt9MatchFlagEE@Base 19.12.1-1 _ZNK3KTp13PresenceModel8rowCountERK11QModelIndex@Base 15.04.2 _ZNK3KTp13PresenceModel9roleNamesEv@Base 15.04.2 _ZNK3KTp17AccountsListModel10metaObjectEv@Base 15.04.2 - _ZNK3KTp17AccountsListModel11columnCountERK11QModelIndex@Base 15.04.2 +#MISSING: 19.12.1-1# _ZNK3KTp17AccountsListModel11columnCountERK11QModelIndex@Base 15.04.2 _ZNK3KTp17AccountsListModel19connectionStateIconERKN2Tp9SharedPtrINS1_7AccountEEE@Base 15.04.2 _ZNK3KTp17AccountsListModel21connectionStateStringERKN2Tp9SharedPtrINS1_7AccountEEE@Base 15.04.2 _ZNK3KTp17AccountsListModel22connectionStatusReasonERKN2Tp9SharedPtrINS1_7AccountEEE@Base 15.04.2 _ZNK3KTp17AccountsListModel3getEiRK10QByteArray@Base 19.12.1 _ZNK3KTp17AccountsListModel4dataERK11QModelIndexi@Base 15.04.2 - _ZNK3KTp17AccountsListModel5indexEiiRK11QModelIndex@Base 15.04.2 +#MISSING: 19.12.1-1# _ZNK3KTp17AccountsListModel5indexEiiRK11QModelIndex@Base 15.04.2 + _ZNK3KTp17AccountsListModel7Private10metaObjectEv@Base 19.12.1-1 _ZNK3KTp17AccountsListModel8rowCountERK11QModelIndex@Base 15.04.2 _ZNK3KTp17AccountsListModel9roleNamesEv@Base 15.04.2 _ZNK3KTp17ContactsListModel10metaObjectEv@Base 15.04.2 dh_makeshlibs: error: failing due to earlier errors make[1]: *** [/usr/share/pkg-kde-tools/qt-kde-team/3/dhmk.mk:97: pre_binary_dh_makeshlibs] Error 25
-- https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-kde-talk
