Alle sabato 31 marzo 2012, Praveen Arimbrathodiyil ha scritto:
> On 10/02/11 14:31, Pino Toscano wrote:
> > Alle domenica 2 ottobre 2011, Praveen A ha scritto:
> >> Someone please review the changes and upload. All changes are in
> >> git repo.
> Thanks for your review. Sorry for getting back so late on this.

No problem.

> > - what's the point of a symbols file, if you set a strict shlibs
> > manually with dh_makeshlibs? Either drop the strict shlibs, or the
> > symbols file
> I will change it after I fix dbg package.

This still holds (why is still "blocked" by the debug package issue?)

> > - given you need an upload to NEW, why not use the opportunity to
> > add a libdbusmenu-qt-dbg debug package?
> I followed steps mentioned in but
> the created package does not have any shared library. Is there any
> other step I need to do?

You're using compat 9, did you look at the changelog for dh_strip in the 
debhelper(7) manpage? In particular:
> - dh_strip puts separated debug symbols in a location based on their
>   build-id.
so you should have something in /usr/lib/debug/.build-id/ in 
libdbusmenu-qt-dbg, don't you?

- you are using compat 9 but still build depending on a debhelper 8.x;
  why not just bump the debhelper build dependency to >= 9, now, so you
  don't need the source lintian override?
- you might want to see about adopting Standards-Version 3.9.3
- why, months ago, did you push a debian/0.9.0-2 tag, if that version
  was not even uploaded (to NEW)? with DVCSes like git, please do *not*
  push tags of versions that are not ACCEPTed in archive, yet.
- the watch file says there's a new version, 0.9.2, available upstream;
  please consider upgrading to that, if it's safe enough.       

Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply via email to