On Tue, May 12, 2015 at 3:50 PM, Harald Sitter <sit...@kde.org> wrote:
> On Tue, May 12, 2015 at 3:29 PM, Lisandro Damián Nicanor Pérez
> <perezme...@gmail.com> wrote:
>> On Tuesday 12 May 2015 14:42:50 Harald Sitter wrote:
>>> alohas
>>>
>>> so, today Martin Gräßlin and I worked out that pkg-kde-tools somehow
>>> lost flags in the process of porting to kf5. in particular:
>>>
>>> ./datalib/kf5_flags:-DCMAKE_BUILD_TYPE=Debian
>>>
>>> was originally backed by the kde4libs patch
>>>
>>> http://paste.ubuntu.com/11095296/
>>>
>>> which was not carried into kf5/ecm.
>>>
>>> Does anyone actually know why we have a custom build type instead of
>>> simply using RelWithDebInfo which does *exactly* the same thing and
>>> doesn't depend on some silly patch?
>>
>> I don't remember the details, but I think that comes from my first days in 
>> the
>> team and the change was introduced by Modestas.
>>
>> Sune or Pino might remember.
>>
>> And it might have been due to RelWithDebInfo not being enough at that time,
>> which doesn't means it is now, a lot has changed.
>>
>>> And in case no one remembers, does anyone have objections to simply
>>> switch this to RelWithDebInfo moving forward?
>>
>> What are the code differences between both? I mean, to see if that hints us 
>> at
>> something.
>
> http://paste.ubuntu.com/11096221/

Actually -g probably is  a bit meh. So RelWithDebInfo might not be best.
- Release type would only add -O2 (on KF5 it actually adds O3 apparently)
- MinSizeRel type would only add -Os which apparently is O2 but trying
to create the smallest possible binary

HS

-- 
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-talk

Reply via email to