On Wed, May 13, 2015 at 7:52 AM, Sune Vuorela <s...@vuorela.dk> wrote: > On Wednesday 13 May 2015 00:30:19 Lisandro Damián Nicanor Pérez Meyer wrote: >> On Tuesday 12 May 2015 23:25:18 Sune Vuorela wrote: >> > On Tuesday 12 May 2015 13:04:42 Lisandro Damián Nicanor Pérez Meyer wrote: >> > > * -O2 is removed to let dpkg-buildflags use whatever we decide in Debian >> > > should be used. >> > >> > I'm pretty sure this is the reason both for -O2 and for -g.
As I pointed out RelWithDebInfo is not actually the best fit anyway because of the -g. So, my original proposal here was rubbish really. What we'd want is 'Release' which is adding -O3 for kf5/ecm. Personally I do not see the advantage in not having it build with optimization. From what I understand the primary effect of not passing -O3 is gcc defaulting to -O0 which is apparently compiling faster at the expense of slower execution time (as in: not as fast execution as if it had been compiled with O3). Considering any given binary is executed many times more than it is built that seems like a disadvantage to me. >> Then the Debian build mode should be kept. > > I'm pretty sure KDE doesn't do build modes any longer, so it is completely up > to cmake. Indeed. ECM from what I can see only *adds* flags useful for KDE software to what cmake picked for the BUILD_TYPE specified by the user. Stuff like default hiding of symbols and LARGEFILE64. The BULD_TYPE flags we currently get in kf5 builds is coming from /usr/share/cmake-3.0/Modules/Compiler/GNU.cmake. IMO this coming directly from cmake is one more reason to not diverge unless we have a really good reason to do so, otherwise one could just as well argue changing the Release flags in the cmake package to not have -O3. HS -- http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-talk