On martes, 16 de agosto de 2016 2:51:17 P. M. ART Simon Quigley wrote:
> Hello everyone,
> So it seems QtSpeech packaging hasn't started yet:
> https://anonscm.debian.org/cgit/pkg-kde/qt/qtspeech.git/
> It also seems like there's no tag yet:
> http://code.qt.io/cgit/qt/qtspeech.git/
> I would like to start initial packaging using a daily tarball. I've
> pushed my work here, https://git.launchpad.net/~tsimonq2/+git/qtspeech
> Let me know what you think.

Here goes my review:

= debian/changelog

If you intend this package to be under the Qt/KDE team umbrella you need to 
follow the [changelog guidelines]. In this specific case the changelog should 
be "signed" by the team's e-mail until the package is released (section 1 of 
the link).

[changelog guidelines] <http://pkg-kde.alioth.debian.org/

= debian/control

- Do you really need chrpath? If you do then you have probably found a bug 

- What do you need kbd for? It's not a development package per-se. Maybe 

- Vcs-[Browser Git]: you probably used your launchpad one for the initial 
setup, but if you point to push it to our repos feel free to use the team's 

- Homepage: I still think that pointing to the docs it's not the right 
homepage, but it might be a matter of taste.

- And the package needs a better description, but that's clearly a WIP.

= debian/copyright: clearly WIP.

= debian/rules: it seems to come from a webkit-related package. Do you really 
need to set which archs get -gstabs? This needs a mjor overhaul. Moreover for 
simple submodules like I think this will be it's easier to start with a plain 
debian/rules or a templated one.

= git

Use one commit per related changes. As you are starting the packaging you 
might want to use one commit per file. Except the commit it's related to two 
or more files, of course. Example: if you add a package in debian/control and 
that package provides a .install file, then they should happen in the same 
commit. Of course we are not perfect and we make mistakes: if you accidentally 
pushed something that oversees this and if it's not too much of a hazzle, just 
keep it like this.


Lisandro Damián Nicanor Pérez Meyer

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply via email to