warm welcome in packaging world !

so I started to review the version on mentors. My comments may be too short to 
you to understand, feel free to ask if you don't understand a point or have 
different opinion in some points, some of the points are recommendations. 

* why you use only i386 and amd64 in your control file? It should be "any" to 
be built on any arch
* Replaces: libkpmcore2 / Replaces: libkpmcore2-dev should be removed, because 
we have not these pacakges in Debian. Btw. you combile Replace with Conflicts 
or Breaks. But normally these are not needed.
* should i be part of the Qt/KDE Debian/Ubuntu umbrella?
*update the VSC links to debian ons

* rename dev package to kpmcore-dev ( or is the API that version dependend?) 
* bump to debhelper 10 

* bump to uscan version 4 that has nice features @PACKAGE@, @ANY_VERSION@, etc 
that makes watch list easier to copy around. [1]

cmake/modules/FindLIBPARTED.cmake is BSD-3-clause

* for c++ ABIs you really want to use symbols-helper, because it helps you 
marking internal symbols as those. [2] Please follow the reference how to use 
the pkgkde-symbolshelper and update the symbolsfile accordingly. [3]
Than you don't need no  override_dh_makeshlibs. Btw. the upstream version you 
can get by use "include /usr/share/dpkg/default.mk" after that you have 

* split everything that is not the lib itself to another package (kpmcore-
  -> do you know who consumes the qt5 plugins?

Best Regards,


[1] https://anonscm.debian.org/git/pkg-kde/qt/qtwebchannel.git/tree/debian/
[2] https://anonscm.debian.org/git/pkg-kde/qt/qtwebchannel.git/tree/debian/
[3] http://pkg-kde.alioth.debian.org/symbolfiles.html

Am Donnerstag, 10. November 2016, 19:52:24 CET schrieb Jonathan Carter:
> Hi Debian Qt/KDE Maintainers!
> I need some assistance with packaging a library called kpmcore.
> Upstream git: https://github.com/KDE/kpmcore
> ITP: https://bugs.debian.org/810063
> RFS: https://bugs.debian.org/837748
> My package on mentors: https://mentors.debian.net/package/kpmcore
> It works and lintian doesn't complain, but I'm new to C++ and KDE
> packages so any feedback would be appreciated.
> thanks!
> -Jonathan

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply via email to