Package: lustre-tests
Severity: important
Version: 1.6.7-2
User: debian-rele...@lists.debian.org
Usertags: goal-dash

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' package)
check I've found your package containing a /bin/sh script making use
of a bashism.

checkbashisms' output:
> possible bashism in ./usr/lib/lustre/tests/mdsrate-stat-large.sh line 33
> (${parm/?/pat[/str]}):
> NUM_CLIENTS=$(get_node_count ${NODES_TO_USE//,/ })
> possible bashism in ./usr/lib/lustre/tests/mdsrate-stat-large.sh line 64
> (${parm/?/pat[/str]}):
>     NUM_CLIENTS=$(get_node_count ${NODES_TO_USE//,/ })
> possible bashism in ./usr/lib/lustre/tests/mdsrate-stat-large.sh line 71
> ($PIPESTATUS):
>     [ ${PIPESTATUS[0]} != 0 ] && error "mpirun ... mdsrate ... file
> creation failed, aborting"
> possible bashism in ./usr/lib/lustre/tests/mdsrate-stat-large.sh line 71
> (bash arrays, ${name[0|*|@]}):
>     [ ${PIPESTATUS[0]} != 0 ] && error "mpirun ... mdsrate ... file
> creation failed, aborting"
> possible bashism in ./usr/lib/lustre/tests/mdsrate-stat-large.sh line 89
> ($PIPESTATUS):
>     if [ ${PIPESTATUS[0]} != 0 ]; then
> possible bashism in ./usr/lib/lustre/tests/mdsrate-stat-large.sh line 89
> (bash arrays, ${name[0|*|@]}):
>     if [ ${PIPESTATUS[0]} != 0 ]; then
> possible bashism in ./usr/lib/lustre/tests/mdsrate-stat-large.sh line 103
> (${parm/?/pat[/str]}):
>     NUM_THREADS=$(get_node_count ${NODES_TO_USE//,/ })
> possible bashism in ./usr/lib/lustre/tests/mdsrate-stat-large.sh line 106
> ($PIPESTATUS):
>     if [ ${PIPESTATUS[0]} != 0 ]; then
> possible bashism in ./usr/lib/lustre/tests/mdsrate-stat-large.sh line 106
> (bash arrays, ${name[0|*|@]}):
>     if [ ${PIPESTATUS[0]} != 0 ]; then
> possible bashism in ./usr/lib/lustre/tests/rundbench line 59 (should be 'b
> = a'):
> if [ "x$CHROOT" == "xyes" ]; then
> possible bashism in ./usr/lib/lustre/tests/llog-test.sh line 39 (should be
> 'b = a'):
> if [ "$ONLY" == "cleanup" ]; then


Not using bash (or a Debian Policy conformant shell interpreter which doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours.
Please be aware that although bash is currently the default /bin/sh there was
a release goal for Lenny to make dash the default /bin/sh[1], and has been
proposed for squeeze as well[2].

If you want more information about dash as /bin/sh, you can read:
http://lists.debian.org/debian-release/2008/01/msg00189.html

For more information supporting this goal please refer to Debian Policy,
section 10.4, at:
http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts

Hints about how to fix bashisms:
Sometimes these bugs are already fixed in Ubuntu, look at the PTS.
If not already fixed you can read:
https://wiki.ubuntu.com/DashAsBinSh

If you still don't know how to fix the bashisms don't hesitate to reply to
this email, or tag the bug as 'help'.

[1]http://release.debian.org/lenny/goals.txt
[2]http://lists.debian.org/debian-release/2009/04/msg00133.html

Thank you,
Raphael Geissert



_______________________________________________
Pkg-lustre-maintainers mailing list
Pkg-lustre-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-lustre-maintainers

Reply via email to