Hi, please apply the attached patch. It fixes the case where the upstream 
changelog contains non-ascii characters.

On 05/05/14 03:09, Ximin Luo wrote:
> On 02/05/14 06:02, Jakub Wilk wrote:
>> * Ximin Luo <infini...@pwned.gg>, 2014-05-02, 01:42:
>>> To save some round trips I pre-emptively used the ISC license for 
>>> consistency with the existing package. Of course Jakub as the original 
>>> author gets to pick the license, so please tell us if you agree with ISC or 
>>> would prefer something different.
>>
>> I agree. :) Thanks for your work.
>>
> 
> Welcome!
> 
> As requested by bdrung here is a follow-up that has a nicer error message for 
> unknown/empty extensions.
> 
> X
> 

-- 
GPG: 4096R/1318EFAC5FBBDBCE
git://github.com/infinity0/pubkeys.git
From 3797a94f3fb8e262736d2a031fba4461eeca536a Mon Sep 17 00:00:00 2001
From: Ximin Luo <infini...@pwned.gg>
Date: Sat, 17 May 2014 16:26:01 +0100
Subject: [PATCH] amo-changelog: output utf-8 by default instead of ascii,
 which errors when the input contains non-ascii chars

---
 amo-changelog | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/amo-changelog b/amo-changelog
index ad4a823..4ce9e73 100755
--- a/amo-changelog
+++ b/amo-changelog
@@ -45,12 +45,12 @@ def main():
         for _, element in etree.iterparse(fp):
             if element.tag != "item":
                 continue
-            title = element.find("title").text
+            title = element.find("title").text.encode("utf-8")
             print(title)
             print("=" * len(title))
             descel = element.find("description")
             if descel is not None and descel.text:
-                print(descel.text.rstrip("\n"))
+                print(descel.text.rstrip("\n").encode("utf-8"))
             else:
                 print("[no description]")
             print("")
-- 
2.0.0.rc0

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Pkg-mozext-maintainers mailing list
Pkg-mozext-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-mozext-maintainers

Reply via email to