On 27/11/14 21:59, u wrote:
> Hi Ximin,
> 
>> Although I cannot sponsor things (not a DD) I will find some time to review 
>> this next week. Sorry for the delay and thanks for the work!
> 
> thanks, that sounds perfect.
> 
> I have a regular sponsor whom I will ask after review :)
> 
> Cheers!
> u.
> 

Hey, here's a first pass:

- debian/README.Debian: most of this should be pushed upstream, README.Debian 
is for Debian-specific stuff.

- debian/copyright: missing the Header stanza

  
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#header-paragraph

- debian/copyright: can merge some of the Files paragraphs by listing multiple 
files in the Files: line

  https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#files-field
  "Filename patterns in the Files field are specified using a simplified shell 
glob syntax. Patterns are separated by whitespace."

- debian/copyright: don't include the whole GPL-3, just point to 
common-licenses, like here:

  https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#examples

- debian/compat: any particular reason 7 and not 9? if not, change it to 9 as 
that's the latest

- debian/changelog: two spaces between "--  Ulrike" makes dpkg-buildpackage 
think it's an NMU, fix this to one space

- debian/control: should use newest standards-version, 3.9.6

several more lintian warnings:

E: cryptocat source: source-is-missing chrome/content/data/js/lib/tinycon.js
E: cryptocat source: source-is-missing chrome/content/data/js/lib/mousetrap.js
E: cryptocat source: source-is-missing 
chrome/content/data/js/lib/jquery/jquery.js
E: cryptocat source: source-is-missing 
chrome/content/data/js/lib/jquery/jquery.color.js
W: xul-ext-cryptocat: extra-license-file usr/share/xul-ext/cryptocat/LICENSE.txt
W: xul-ext-cryptocat: embedded-javascript-library 
usr/share/xul-ext/cryptocat/chrome/content/data/js/lib/jquery/jquery.js please 
use libjs-jquery
W: xul-ext-cryptocat: embedded-javascript-library 
usr/share/xul-ext/cryptocat/chrome/content/data/js/lib/strophe/strophe.js 
please use libjs-strophe

X

-- 
GPG: 4096R/1318EFAC5FBBDBCE
git://github.com/infinity0/pubkeys.git

_______________________________________________
Pkg-mozext-maintainers mailing list
Pkg-mozext-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-mozext-maintainers

Reply via email to