Your message dated Fri, 08 Apr 2022 09:49:51 +0000
with message-id <[email protected]>
and subject line Bug#927095: fixed in mediaconch 22.03-2
has caused the Debian Bug report #927095,
regarding mediaconch FTCBFS: hard codes the build architecture pkg-config
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
927095: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=927095
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: mediaconch
Version: 18.03.2-1
Tags: patch upstream
User: [email protected]
Usertags: rebootstrap

mediaconch fails to cross build from source, because its upstream build
system (both autoconf and qmake) hard code the build architecture
pkg-config rather than using the supplied one. Thus it fails finding
relevant libraries that are only requested for the host architecture by
Build-Depends. The attached patch fixes the relevant pkg-config
invocations in a minimal manner. For autotools, it would be better to
use the PKG_CHECK_MODULES_MACRO. Still the patch makes mediaconch cross
buildable. Please consider applying it as an incremental step with low
risk of breakage.

Helmut
--- mediaconch-18.03.2.orig/Project/GNU/CLI/configure.ac
+++ mediaconch-18.03.2/Project/GNU/CLI/configure.ac
@@ -28,6 +28,7 @@
 AC_PROG_CXX
 AC_PROG_INSTALL
 LT_INIT
+PKG_PROG_PKG_CONFIG
 
 dnl #########################################################################
 dnl ### Options
@@ -74,8 +75,8 @@
 elif test "$(libzen-config Exists)" = "yes" ; then
 	enable_unicode="$(libzen-config Unicode)"
 else
-	if pkg-config --exists libzen; then
-		enable_unicode="$(pkg-config --variable=Unicode libzen)"
+	if $PKG_CONFIG --exists libzen; then
+		enable_unicode="$($PKG_CONFIG --variable=Unicode libzen)"
 	else
 		AC_MSG_ERROR([libzen configuration is not found])
 	fi
@@ -181,14 +182,14 @@
 			LIBS="$LIBS $(libmediainfo-config LIBS)"
 		fi
 	else
-		if pkg-config --exists lib$with_libmediainfo_name; then
-			CXXFLAGS="$CXXFLAGS $(pkg-config --cflags libmediainfo)"
+		if $PKG_CONFIG --exists lib$with_libmediainfo_name; then
+			CXXFLAGS="$CXXFLAGS $($PKG_CONFIG --cflags libmediainfo)"
 			if test "$enable_staticlibs" = "yes"; then
 				with_mediainfolib="system (static)"
-				LIBS="$LIBS $(pkg-config --variable=Libs_Static lib$with_libmediainfo_name)"
+				LIBS="$LIBS $($PKG_CONFIG --variable=Libs_Static lib$with_libmediainfo_name)"
 			else
 				with_mediainfolib="system"
-				LIBS="$LIBS $(pkg-config --libs lib$with_libmediainfo_name)"
+				LIBS="$LIBS $($PKG_CONFIG --libs lib$with_libmediainfo_name)"
 			fi
 		else
 			AC_MSG_ERROR([libmediainfo configuration is not found])
@@ -222,15 +223,15 @@
 		LIBS="$LIBS $(libzen-config LIBS)"
 	fi
 else
-	if pkg-config --exists libzen; then
-		CXXFLAGS="$CXXFLAGS $(pkg-config --cflags libzen)"
-		MediaInfoLib_CXXFLAGS="$MediaInfoLib_CXXFLAGS $(pkg-config --cflags libzen)"
+	if $PKG_CONFIG --exists libzen; then
+		CXXFLAGS="$CXXFLAGS $($PKG_CONFIG --cflags libzen)"
+		MediaInfoLib_CXXFLAGS="$MediaInfoLib_CXXFLAGS $($PKG_CONFIG --cflags libzen)"
 		if test "$enable_staticlibs" = "yes"; then
 			with_zenlib="system (static)"
-			LIBS="$LIBS $(pkg-config --variable=Libs_Static libzen)"
+			LIBS="$LIBS $($PKG_CONFIG --variable=Libs_Static libzen)"
 		else
 			with_zenlib="system"
-			LIBS="$LIBS $(pkg-config --libs libzen)"
+			LIBS="$LIBS $($PKG_CONFIG --libs libzen)"
 		fi
 	else
 		AC_MSG_ERROR([libzen configuration is not found])
@@ -251,25 +252,25 @@
 		LIBS="$LIBS  -L../../../../libxml2/.libs -lxml2"
 	fi
 else
-	if pkg-config --exists libxml2; then
-		CXXFLAGS="$CXXFLAGS $(pkg-config --cflags libxml2)"
-		MediaInfoLib_CXXFLAGS="$MediaInfoLib_CXXFLAGS $(pkg-config --cflags libxml2)"
+	if $PKG_CONFIG --exists libxml2; then
+		CXXFLAGS="$CXXFLAGS $($PKG_CONFIG --cflags libxml2)"
+		MediaInfoLib_CXXFLAGS="$MediaInfoLib_CXXFLAGS $($PKG_CONFIG --cflags libxml2)"
 		if test "$enable_staticlibs" = "yes"; then
 			with_libxml2="system (static)"
-			LIBS="$LIBS $(pkg-config --static --libs libxml2)"
+			LIBS="$LIBS $($PKG_CONFIG --static --libs libxml2)"
 		else
 			with_libxml2="system"
-			LIBS="$LIBS $(pkg-config --libs libxml2)"
+			LIBS="$LIBS $($PKG_CONFIG --libs libxml2)"
 		fi
-	elif pkg-config --exists libxml-2.0; then
-		CXXFLAGS="$CXXFLAGS $(pkg-config --cflags libxml-2.0)"
-		MediaInfoLib_CXXFLAGS="$MediaInfoLib_CXXFLAGS $(pkg-config --cflags libxml-2.0)"
+	elif $PKG_CONFIG --exists libxml-2.0; then
+		CXXFLAGS="$CXXFLAGS $($PKG_CONFIG --cflags libxml-2.0)"
+		MediaInfoLib_CXXFLAGS="$MediaInfoLib_CXXFLAGS $($PKG_CONFIG --cflags libxml-2.0)"
 		if test "$enable_staticlibs" = "yes"; then
 			with_libxml2="system (static)"
-			LIBS="$LIBS $(pkg-config --static --libs libxml-2.0)"
+			LIBS="$LIBS $($PKG_CONFIG --static --libs libxml-2.0)"
 		else
 			with_libxml2="system"
-			LIBS="$LIBS $(pkg-config --libs libxml-2.0)"
+			LIBS="$LIBS $($PKG_CONFIG --libs libxml-2.0)"
 		fi
 	else
 		AC_MSG_ERROR([libxml2 configuration is not found])
@@ -293,19 +294,19 @@
 		LIBS="$LIBS  -L../../../../libxslt/libexslt/.libs -lexslt"
 	fi
 else
-	if pkg-config --exists libxslt; then
-		CXXFLAGS="$CXXFLAGS $(pkg-config --cflags libxslt)"
-		CXXFLAGS="$CXXFLAGS $(pkg-config --cflags libexslt)"
-		MediaInfoLib_CXXFLAGS="$MediaInfoLib_CXXFLAGS $(pkg-config --cflags libxslt)"
-		MediaInfoLib_CXXFLAGS="$MediaInfoLib_CXXFLAGS $(pkg-config --cflags libexslt)"
+	if $PKG_CONFIG --exists libxslt; then
+		CXXFLAGS="$CXXFLAGS $($PKG_CONFIG --cflags libxslt)"
+		CXXFLAGS="$CXXFLAGS $($PKG_CONFIG --cflags libexslt)"
+		MediaInfoLib_CXXFLAGS="$MediaInfoLib_CXXFLAGS $($PKG_CONFIG --cflags libxslt)"
+		MediaInfoLib_CXXFLAGS="$MediaInfoLib_CXXFLAGS $($PKG_CONFIG --cflags libexslt)"
 		if test "$enable_staticlibs" = "yes"; then
 			with_libxslt="system (static)"
-			LIBS="$LIBS $(pkg-config --static --libs libxslt)"
-			LIBS="$LIBS $(pkg-config --static --libs libexslt)"
+			LIBS="$LIBS $($PKG_CONFIG --static --libs libxslt)"
+			LIBS="$LIBS $($PKG_CONFIG --static --libs libexslt)"
 		else
 			with_libxslt="system"
-			LIBS="$LIBS $(pkg-config --libs libxslt)"
-			LIBS="$LIBS $(pkg-config --libs libexslt)"
+			LIBS="$LIBS $($PKG_CONFIG --libs libxslt)"
+			LIBS="$LIBS $($PKG_CONFIG --libs libexslt)"
 		fi
 	else
 		AC_MSG_ERROR([libxslt configuration is not found])
@@ -325,14 +326,14 @@
             with_libsqlite3="builtin"
             LIBS="$LIBS  -L../../../../sqlite/.libs -lsqlite3"
         fi
-    elif pkg-config --exists sqlite3; then
-        CXXFLAGS="$CXXFLAGS -DHAVE_SQLITE $(pkg-config --cflags sqlite3)"
+    elif $PKG_CONFIG --exists sqlite3; then
+        CXXFLAGS="$CXXFLAGS -DHAVE_SQLITE $($PKG_CONFIG --cflags sqlite3)"
         if test "$enable_staticlibs" = "yes"; then
             with_libsqlite3="system (static)"
-            LIBS="$LIBS $(pkg-config --static --libs sqlite3)"
+            LIBS="$LIBS $($PKG_CONFIG --static --libs sqlite3)"
         else
             with_libsqlite3="system"
-            LIBS="$LIBS $(pkg-config --libs sqlite3)"
+            LIBS="$LIBS $($PKG_CONFIG --libs sqlite3)"
         fi
     else
         AC_MSG_ERROR([libsqlite3 configuration is not found])
@@ -354,14 +355,14 @@
             with_libjansson="builtin"
             LIBS="$LIBS  -L../../../../jansson/src/.libs -ljansson"
         fi
-    elif pkg-config --exists jansson; then
-        CXXFLAGS="$CXXFLAGS -DHAVE_JANSSON $(pkg-config --cflags jansson)"
+    elif $PKG_CONFIG --exists jansson; then
+        CXXFLAGS="$CXXFLAGS -DHAVE_JANSSON $($PKG_CONFIG --cflags jansson)"
         if test "$enable_staticlibs" = "yes"; then
             with_libjansson="system (static)"
-            LIBS="$LIBS $(pkg-config --static --libs jansson)"
+            LIBS="$LIBS $($PKG_CONFIG --static --libs jansson)"
         else
             with_libjansson="system"
-            LIBS="$LIBS $(pkg-config --libs jansson)"
+            LIBS="$LIBS $($PKG_CONFIG --libs jansson)"
         fi
     else
         AC_MSG_ERROR([libjansson configuration is not found])
@@ -383,14 +384,14 @@
             with_libevent="builtin"
             LIBS="$LIBS  -L../../../../libevent/.libs -levent"
         fi
-    elif pkg-config --exists libevent; then
-        CXXFLAGS="$CXXFLAGS -DHAVE_LIBEVENT $(pkg-config --cflags libevent)"
+    elif $PKG_CONFIG --exists libevent; then
+        CXXFLAGS="$CXXFLAGS -DHAVE_LIBEVENT $($PKG_CONFIG --cflags libevent)"
         if test "$enable_staticlibs" = "yes"; then
             with_libevent="system (static)"
-            LIBS="$LIBS $(pkg-config --static --libs libevent)"
+            LIBS="$LIBS $($PKG_CONFIG --static --libs libevent)"
         else
             with_libevent="system"
-            LIBS="$LIBS $(pkg-config --libs libevent)"
+            LIBS="$LIBS $($PKG_CONFIG --libs libevent)"
         fi
     else
         AC_MSG_ERROR([libevent configuration is not found])
--- mediaconch-18.03.2.orig/Project/Qt/MediaConch.pro
+++ mediaconch-18.03.2/Project/Qt/MediaConch.pro
@@ -38,9 +38,10 @@
     }
 }
 
+PKG_CONFIG = $$pkgConfigExecutable()
 !defined(packagesExist, test) {
     defineTest(packagesExist) {
-        system(pkg-config $$ARGS): return(true)
+        system($$PKG_CONFIG $$ARGS): return(true)
         return(false)
     }
 }
@@ -230,7 +231,7 @@
     !packagesExist(libmediainfo) {
         error("libmediainfo not found on system")
     }
-    LIBS += $$system(pkg-config --libs libmediainfo)
+    PKGCONFIG += libmediainfo
 }
 
 unix:exists(../../../ZenLib/Project/GNU/Library/libzen-config) {

--- End Message ---
--- Begin Message ---
Source: mediaconch
Source-Version: 22.03-2
Done: Chow Loong Jin <[email protected]>

We believe that the bug you reported is fixed in the latest version of
mediaconch, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chow Loong Jin <[email protected]> (supplier of updated mediaconch package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 08 Apr 2022 17:25:56 +0800
Source: mediaconch
Built-For-Profiles: noudeb
Architecture: source
Version: 22.03-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers 
<[email protected]>
Changed-By: Chow Loong Jin <[email protected]>
Closes: 927095
Changes:
 mediaconch (22.03-2) unstable; urgency=medium
 .
   * [80dc663] Patch to stop hardcoding pkg-config executable (Closes: #927095)
Checksums-Sha1:
 54c087f34ae656184c4644c15d96760bf712f32e 2257 mediaconch_22.03-2.dsc
 d6d378ead5118e8c28aff5614390e3c23eb2919e 17864 mediaconch_22.03-2.debian.tar.xz
 6d0b94af70cf609559e68b7faf318ac1e9e64173 12632 
mediaconch_22.03-2_source.buildinfo
Checksums-Sha256:
 1c07b1912f40ae0bfae6df4cb3dc39bc4d5c40fa3a81624b43f3ca7e757c5bc7 2257 
mediaconch_22.03-2.dsc
 a1e70f015f8edefc4887e4d72c94a56e5fb5ef941c9744aeaaed03cdccc67575 17864 
mediaconch_22.03-2.debian.tar.xz
 7edb04e6154bc9d4ee062f619da7032bf44e025cb62e3e519e3dcf1b1e07b642 12632 
mediaconch_22.03-2_source.buildinfo
Files:
 d51429302ae165265822fb26d3978fd1 2257 utils optional mediaconch_22.03-2.dsc
 b6a6f871f7b57fdbae5379861ec0908e 17864 utils optional 
mediaconch_22.03-2.debian.tar.xz
 e761f890cd51e90220d12b36e6b08c4b 12632 utils optional 
mediaconch_22.03-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEEuDQnfs/9/dZ027Q+9UiW1iHUqEFAmJQAT4ACgkQ+9UiW1iH
UqH19BAAglNl1W2GAbeR05wb2vS3voCrAdN4B+LNSu5Aie55iVNHigHk03mwg2NA
3gFHReVbnTLHRk42VVUj72G2Y/UYILQd3jayxsUqmLEU0jwrgS2uQILpT52k1/6a
atPcJ5UjJZ339jcHrXqZmfO97UlP9K8cLhh1bUWLMpyJCSq3IJsAHHOVyhzwCAP3
jCs2G6EyFIgSiDCT/h5rC/VWbfsIeP7C8voRfO1059MI/3sk0g+hVJ0EN0xotjNc
UnH4kD/U6x5X23rB8C98fKLIDvE/s/zrqPs8Et2OfIHXmp6DkRLUdMTRRCS7/cjo
xWxDtNS3w1UbtIIhSKxSZOdS/ztfcgb9fq041qO0S/Xiu0gvaVDFcpl/uO92AwZQ
ZoA+eiwpu/K+Y/zm9pqF+Ib9VFDKhRbl/kjH8HZH3AeGBT0uszwWaf+rKsHcRaAD
/+j89y9UmEsaIGaJdb6zDhc7VQgJZz3S6drvsnPyrlmnAUO2tZf+cZJUOlyKS31t
KOp2bhiXlnm43BXdDqHKPtanUE6CEzxBoOJCWOqNb1oDP4JIP03R8gKksXQ9sUCW
aqacqek1/tII2j1HggNyBluHPwX0tV4ABVskd6DDSqiwCIBGBUFhY96tYB+l8XUF
MqoNDo3rUJXtRT8CT1tZwB//eD4UzPajb5C0ktwUx4PU1hK0jNE=
=m8z4
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
pkg-multimedia-maintainers mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Reply via email to