Your message dated Sun, 20 Nov 2022 22:51:06 +0000
with message-id <e1owt9w-00bmvt...@fasolo.debian.org>
and subject line Bug#1022130: fixed in tsdecrypt 10.0-2.1
has caused the Debian Bug report #1022130,
regarding tsdecrypt: reproducible-builds: build path embedded in various 
binaries
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1022130: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1022130
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: tsdecrypt
Severity: normal
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

The build path is embedded in various binaries:

  
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/tsdecrypt.html

  /usr/bin/tsdecrypt_dvbcsa

  /build/1st/tsdecrypt-10.0/tsdecrypt.c:948
  vs.
  /build/2/tsdecrypt-10.0/2nd/tsdecrypt.c:948

The attached patch to debian/rules fixes this by passing the default
CFLAGS to the two make invocations, which includes -ffile-prefix-map to
avoid embedding build paths.

According to my local tests, with this patch applied, and the patch
submitted in https://bugs.debian.org/829713, tsdecrypt should build
reproducibly on tests.reproducible-builds.org!

If it would be helpful, I would like to NMU with this patch and the
patch from #829713 in the near future in time for bookworm.

Thanks for maintaining tsdecrypt!

live well,
  vagrant
From 94b07c835c7706b0ad5891458b142e8c4a9158b9 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date: Thu, 20 Oct 2022 17:20:19 +0000
Subject: [PATCH 4/4] debian/rules: Pass default CFLAGS.

---
 debian/rules | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/rules b/debian/rules
index cd33eef..10a8fa7 100755
--- a/debian/rules
+++ b/debian/rules
@@ -10,11 +10,11 @@ override_dh_auto_configure:
 override_dh_auto_build:
 override_dh_auto_install:
 	# Build with FFdecsa
-	$(MAKE) ffdecsa
+	$(MAKE) CFLAGS="$(shell dpkg-buildflags --get CFLAGS)" ffdecsa
 	mv tsdecrypt tsdecrypt_ffdecsa
 	$(MAKE) distclean
 	# Build against libdvbcsa
-	$(MAKE) dvbcsa
+	$(MAKE) CFLAGS="$(shell dpkg-buildflags --get CFLAGS)" dvbcsa
 	mv tsdecrypt tsdecrypt_dvbcsa
 	# Install binaries
 	mkdir -p $(DESTDIR)$(PREFIX)/bin
-- 
2.37.2

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: tsdecrypt
Source-Version: 10.0-2.1
Done: Vagrant Cascadian <vagr...@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
tsdecrypt, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1022...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagr...@reproducible-builds.org> (supplier of updated 
tsdecrypt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 10 Nov 2022 13:54:44 -0800
Source: tsdecrypt
Architecture: source
Version: 10.0-2.1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers 
<pkg-multimedia-maintain...@lists.alioth.debian.org>
Changed-By: Vagrant Cascadian <vagr...@reproducible-builds.org>
Closes: 829713 1022130
Changes:
 tsdecrypt (10.0-2.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Reiner Herrmann ]
   * strip build date to enable reproducible building (Closes: #829713)
 .
   [ Vagrant Cascadian ]
   * debian/rules: Pass default CFLAGS. (Closes: #1022130)
Checksums-Sha1:
 c8f19eddbdc499ec1a5fc0119c66520c210a2df6 1558 tsdecrypt_10.0-2.1.dsc
 b2e08ad640a91472e18d8cf15f5ecac21d6d26bf 5332 tsdecrypt_10.0-2.1.debian.tar.xz
Checksums-Sha256:
 aee46ab8029687a845187d0104d43bf674d82aa5a9ab276e5078db1799a2399b 1558 
tsdecrypt_10.0-2.1.dsc
 dba0edad2921c27605413feb79355563f0accfb2d18955d7e4d8d50509e179d1 5332 
tsdecrypt_10.0-2.1.debian.tar.xz
Files:
 39fa38019ad788a63c6ae05fdaa223bb 1558 video optional tsdecrypt_10.0-2.1.dsc
 90943127c742290c172a27f5ad003a73 5332 video optional 
tsdecrypt_10.0-2.1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY210/CAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqsbCAQD8447lMqI0bFdT
Cpy/VWmlKWltGbsN/QPaHOAQ4aKAmgEAqus4BiNBmsTSgraY1PPtHhih5XjtXMT8
mzMbIEqj1gg=
=GLI3
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Reply via email to