Your message dated Wed, 27 Sep 2023 09:55:10 +0000
with message-id <e1qlrga-00cju4...@fasolo.debian.org>
and subject line Bug#901452: fixed in jack-midi-clock 0.4.3-2
has caused the Debian Bug report #901452,
regarding jack-midi-clock FTCBFS: upstream Makefile hard codes build 
architecture pkg-config
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
901452: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901452
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: jack-midi-clock
Version: 0.4.3-1
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap

jack-midi-clock fails to cross build from source, because the upstream
Makefile hard codes the build architecture pkg-config. After making it
substitutable, it still fails, because dh_auto_clean does not pass cross
tools and that's fatal to the Makefile. Using dpkg's buildtools.mk, we
can export cross tools for all targets and that makes jack-midi-clock
cross buildable. Please consider applying the attached patch.

Helmut
diff --minimal -Nru jack-midi-clock-0.4.3/debian/changelog 
jack-midi-clock-0.4.3/debian/changelog
--- jack-midi-clock-0.4.3/debian/changelog      2016-10-01 23:39:20.000000000 
+0200
+++ jack-midi-clock-0.4.3/debian/changelog      2018-06-13 16:03:03.000000000 
+0200
@@ -1,3 +1,12 @@
+jack-midi-clock (0.4.3-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + cross.patch: Make pkg-config substitutable.
+    + Use dpkg's buildtools.mk to pass cross tools for all targets.
+
+ -- Helmut Grohne <hel...@subdivi.de>  Wed, 13 Jun 2018 16:03:03 +0200
+
 jack-midi-clock (0.4.3-1) unstable; urgency=medium
 
   * New upstream version 0.4.3 (Closes: #839315)
diff --minimal -Nru jack-midi-clock-0.4.3/debian/patches/cross.patch 
jack-midi-clock-0.4.3/debian/patches/cross.patch
--- jack-midi-clock-0.4.3/debian/patches/cross.patch    1970-01-01 
01:00:00.000000000 +0100
+++ jack-midi-clock-0.4.3/debian/patches/cross.patch    2018-06-13 
16:03:03.000000000 +0200
@@ -0,0 +1,28 @@
+--- jack-midi-clock-0.4.3.orig/Makefile
++++ jack-midi-clock-0.4.3/Makefile
+@@ -2,12 +2,13 @@
+ bindir ?= $(PREFIX)/bin
+ mandir ?= $(PREFIX)/share/man
+ 
++PKG_CONFIG ?= pkg-config
+ CFLAGS ?= -Wall -O3
+ VERSION?=$(shell (git describe --tags HEAD 2>/dev/null || echo "v0.4.3") | 
sed 's/^v//')
+ 
+ 
###############################################################################
+ 
+-ifeq ($(shell pkg-config --exists jack || echo no), no)
++ifeq ($(shell $(PKG_CONFIG) --exists jack || echo no), no)
+   $(warning *** libjack from http://jackaudio.org is required)
+   $(error   Please install libjack-dev, libjack-jackd2-dev)
+ endif
+@@ -16,8 +17,8 @@
+ 
+ override CFLAGS += -DWITH_JITTER
+ override CFLAGS += -DVERSION="\"$(VERSION)\""
+-override CFLAGS += `pkg-config --cflags jack`
+-LOADLIBES = `pkg-config --cflags --libs jack` -lm -lpthread
++override CFLAGS += `$(PKG_CONFIG) --cflags jack`
++LOADLIBES = `$(PKG_CONFIG) --cflags --libs jack` -lm -lpthread
+ man1dir   = $(mandir)/man1
+ 
+ 
###############################################################################
diff --minimal -Nru jack-midi-clock-0.4.3/debian/patches/series 
jack-midi-clock-0.4.3/debian/patches/series
--- jack-midi-clock-0.4.3/debian/patches/series 2016-10-01 22:05:16.000000000 
+0200
+++ jack-midi-clock-0.4.3/debian/patches/series 2018-06-13 16:02:43.000000000 
+0200
@@ -1 +1,2 @@
 01-fix_prefix.patch
+cross.patch
diff --minimal -Nru jack-midi-clock-0.4.3/debian/rules 
jack-midi-clock-0.4.3/debian/rules
--- jack-midi-clock-0.4.3/debian/rules  2016-10-01 23:39:20.000000000 +0200
+++ jack-midi-clock-0.4.3/debian/rules  2018-06-13 16:03:03.000000000 +0200
@@ -1,6 +1,9 @@
 #!/usr/bin/make -f
 # -*- makefile -*-
 
+export DPKG_EXPORT_BUILDTOOLS=1
+-include /usr/share/dpkg/buildtools.mk
+
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 
 %:

--- End Message ---
--- Begin Message ---
Source: jack-midi-clock
Source-Version: 0.4.3-2
Done: Bastian Germann <b...@debian.org>

We believe that the bug you reported is fixed in the latest version of
jack-midi-clock, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 901...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bastian Germann <b...@debian.org> (supplier of updated jack-midi-clock package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 27 Sep 2023 10:06:25 +0200
Source: jack-midi-clock
Architecture: source
Version: 0.4.3-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multime...@lists.debian.org>
Changed-By: Bastian Germann <b...@debian.org>
Closes: 901452
Changes:
 jack-midi-clock (0.4.3-2) unstable; urgency=medium
 .
   * Team upload.
 .
   [ Felipe Sateler ]
   * Change maintainer address to debian-multime...@lists.debian.org.
 .
   [ Ondřej Nový ]
   * Use debhelper-compat instead of debian/compat.
 .
   [ Debian Janitor ]
   * Bump debhelper from old 10 to 13.
   * Set upstream metadata fields: Bug-Database, Bug-Submit, Repository-Browse.
 .
   [ Helmut Grohne ]
   * Fix FTCBFS: (Closes: #901452)
     + cross.patch: Make pkg-config substitutable.
     + Use dpkg's buildtools.mk to pass cross tools for all targets.
Checksums-Sha1:
 2464f9667b1e7adf5f6134313a019c0f77b8c74c 1865 jack-midi-clock_0.4.3-2.dsc
 a975bb2f9baf1e91468aa91b943bdab3f414f04b 2796 
jack-midi-clock_0.4.3-2.debian.tar.xz
 8e3253f4affde008a5f935c1fdfb9901ee1ce7ae 5606 
jack-midi-clock_0.4.3-2_source.buildinfo
Checksums-Sha256:
 2c13b92c63db252ee64eaba743474047a1b3fab6dcba79b47d355df3f16c84f3 1865 
jack-midi-clock_0.4.3-2.dsc
 646bf587a36f18a0672f420b8eba841a6c21e3e3ab30d3d51d9e0d3ee4617681 2796 
jack-midi-clock_0.4.3-2.debian.tar.xz
 495126adb78da8024c04417b09b7bb0a7291ff629b2716cd7d3846be744f13d1 5606 
jack-midi-clock_0.4.3-2_source.buildinfo
Files:
 8c63311cab788867ea0b59762378db03 1865 sound optional 
jack-midi-clock_0.4.3-2.dsc
 0dbc88379f833308f346c43d196e5df8 2796 sound optional 
jack-midi-clock_0.4.3-2.debian.tar.xz
 be7e342b017f2466eedf54b2ff1654b1 5606 sound optional 
jack-midi-clock_0.4.3-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQHEBAEBCgAuFiEEQGIgyLhVKAI3jM5BH1x6i0VWQxQFAmUT4usQHGJhZ2VAZGVi
aWFuLm9yZwAKCRAfXHqLRVZDFAyuC/0em+4/i5Ekemo90EW95gwGllve75x8xbHK
6fTtW6M+KWKIrWHruYgm64RZeuTzrSK4QhRhzTtetTlNByiyRZwc5mjrimNCUSFu
RPUBytrkwHUE+t8GTv9owagKYKfPjMTTLQSxWRKeWa0FfW73ka4+FZRLpjiXYK3v
Bu3CVVv6QzU1bnwhqkRfEzgU5+ZWWeNwYRWe6ujBFMz8195HLpMJ1lRcoteJyfTV
jjdTy1BX4nsDM8DZe66GIhSTpelsgVur8kLhP0oDN3fGZTt9480Excfmwm8jp57T
XCuCouVP2w7UP/QMNLs4TrflsGvSoRHMqT0xoIYaUAyiDSb+bkSmKgpGYsRo+Eg3
wiigPKRkSq6jG47rq9Q+hRDIM/fHTj7JkLnY4ibC78sRYn0Qs1Eyy6kPVv53J+dj
hPhKlVLF16z6MC7wh2XleGWP7o1ZpuBvaXUh8jykkoiPEAQsPZ3p6k/vdqJBxxcw
46a6jueGFafKeI0k1ktUq4x+Jsb9EbQ=
=uH4Y
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Reply via email to