Hey Dmitrijs,

some comments on the new debian/copyright file:

Am 10.12.2009 08:29, schrieb Dmitrijs Ledkovs:
Name: liba52
Source: http://liba52.sourceforge.net
Copyright: 2000-2002, Michel Lespinasse<wal...@zoy.org>
        1999-2000, Aaron Holtzman<aholt...@ess.engr.uvic.ca>

Here the copyright information is IMHO redundant, because it will be repeated in the "Files: *" section.

Files: *
Copyright: 2000-2002, Michel Lespinasse<wal...@zoy.org>
        1999-2000, Aaron Holtzman<aholt...@ess.engr.uvic.ca>
License: GPL-2+
  On Debian systems the full text of the GNU General Public
  License can be found in the `/usr/share/common-licenses/GPL-2'

This section is missing the license blurp, which you (accidently?) only added to the "Files: debian/*" section (still refering to a52dec, though).

Let's also add the © UTF-8 copyright symbol in front of the years.

Files: debian/*
Copyright: 2009, Dmitrijs Ledkovs<dmitrij.led...@gmail.com>
        2007-2009, Fabian Greffrath<fab...@debian-unofficial.org
           2007, Sam Hocevar (Debian packages)<sam+...@zoy.org>
        2006-2007, Daniel Baumann<dan...@debian.org>

License: GPL-2+
  a52dec is free software; you can redistribute it and/or modify
  it under the terms of the GNU General Public License as published by
  the Free Software Foundation; either version 2 of the License, or
  (at your option) any later version.

This section indeed has the license blurp, but that does not apply to the a52dec source code here, but to the Debian packaging!

Further comments:

- The indentation of the copyright holders is inconsistent. Please do only use space characters and don't mix them with tabs. I know this is cosmetic, but while we are at it...

- The debian/watch file does not use the sf redirector. I have no idea why lintian does not complain about this, but it should be changed anyway. <http://lintian.debian.org/tags/debian-watch-file-should-use-sf-redirector.html>


Dipl.-Phys. Fabian Greffrath

Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT)
Universitätsstr. 150, IB 3/134
D-44780 Bochum

Telefon: +49 (0)234 / 32-26334
Fax:     +49 (0)234 / 32-14227
E-Mail:  greffr...@leat.ruhr-uni-bochum.de

pkg-multimedia-maintainers mailing list

Reply via email to