On Wed, May 26, 2010 at 06:59:00AM +0000, siret...@users.alioth.debian.org 
wrote:
The following commit has been merged in the master branch:
commit e0636d22570edd78dcc81797f84336ffbd810b95
Author: Reinhard Tartler <siret...@tauware.de>
Date:   Wed May 26 08:30:37 2010 +0200

   copy in mencoder.c from upstream

   this is a cowboy approach that places mencoder.c in
   debian/mencoder.c. This is of course a gross hack and should be reverted
   on the next upstream upgrade.

[ huge patch snippet ]

diff --git a/debian/rules b/debian/rules
index 0ba540f..c9c289d 100755
--- a/debian/rules
+++ b/debian/rules
@@ -93,8 +93,12 @@ endif
# https://wiki.ubuntu.com/DistCompilerFlags
CLEAN_ENV=env -u CFLAGS -u CPPFLAGS -u LDFLAGS -u FFLAGS -u CXXFLAGS

+# cowboy in mencoder.c manually fetched from upstream to avoid having to reroll
+# a new upstream tarball. Will be dropped with a new upstream upgrade
+mencoder.c: debian/mencoder.c

I fail to see the point in hiding upstream code in the Debian packaging - even without mentioning it in debian/copyright!

Rolling a new tarball does not trigger ftpmaster approval through the NEW queue, new binary packages does, so that is bound to happen anyway.

I strongly suggest to either place it as a proper patch with DEP3 header, or roll a new tarball.

And to document its licensing if placed below debian/ .


 - Jonas

--
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Attachment: signature.asc
Description: Digital signature

_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers

Reply via email to