On Wed, May 26, 2010 at 05:22, Dmitrijs Ledkovs
<dmitrij.led...@ubuntu.com> wrote:
> On 26 May 2010 02:24, Felipe Sateler <fsate...@gmail.com> wrote:
>> On Tue, May 25, 2010 at 18:02, Jaromír Mikeš <mira.mi...@seznam.cz> wrote:
>>>> Od: Felipe Sateler <fsate...@gmail.com>
>>>
>>> RT> > The last consensus was that yes, under the condition that the clean
>>> RT> > target of debian rules restores the working copy to a state that is
>>> RT> > ready for git diff/commit operations. Most commongly this means to
>>> RT> > unpatch in the clean target.
>>>
>>> RT> > The intend behind this is to have the same workflow for both Format 
>>> 1.0
>>> RT> > and 3.0 packages.
>>>
>>> FS> Be careful to only unapply patches when in a git repository! Otherwise
>>> FS> you will get misterious FTBFS in the buildds.
>>>
>>> FS> Also, you need to apply them in the build rule (again, only if in the
>>> FS> git repository).
>>>
>>> So if I understand well something like this should be in short dh 7 rules 
>>> file:
>>> override_dh_auto_clean:
>>>  unpatch
>>>  dh_auto_clean
>>>
>>> or something more should be done?
>>
>> More. The unpatch should be done only if within a git repository.
>> Something like:
>>
>> override_dh_auto_clean:
>>  if [ -d .git ] ; then \
>>    quilt pop -a \
>
> dh_quilt_unpatch ?
>
> or even easier
>
> %:
>      dh --with quilt $@

I think (but I'm not sure, I'd love to be proven incorrect) that this
would result in unwanted behaviour when doing a NMU with a 3.0 source
package, because patches would be applied _after_ the NMUers
modification to the package, not before.

-- 

Saludos,
Felipe Sateler

_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers

Reply via email to