Hi all,

I've sent patch solving build problems upstream and upstream has questions 
which I would like to get commented by team members to answer it right and 
avoid misunderstanding in future.

* DESTDIR and the required changes to install are being added
to the Makefile when any of my packasges gets updated.

There's one issue on which I'd want your opinion as
a packager:

What is the best way to refer to 'standard' commands
such as rm, cp, ln, install, ldconfig, etc. etc., in
particular within an 'install' target ?

1. Use the full pathname (which seems to be distro-
   dependent), or
2. Assume they are in the user's or the packaging
   toolset's path, or
3. Use Makefile macros for all of them ?

Things should work both for users intalling directly
from source, and for packaging tools.

Thank you for help.
*patch in attachment


Description: Append PREFIX variable to set installation path properly.
 Set prefix properly and fix install commands.
Author: Jaromír Mikeš <mira.mi...@seznam.cz>
 source/Makefile |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

--- jkmeter.orig/source/Makefile
+++ jkmeter/source/Makefile
@@ -14,8 +14,9 @@
 #  along with this program; if not, write to the Free Software
 #  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
-PREFIX = /usr/local
+PREFIX = /usr
 SUFFIX := $(shell uname -m | sed -e 's/^unknown/$//' -e 's/^i.86/$//' -e 's/^x86_64/$/64/')
 SHARED = $(PREFIX)/share
@@ -43,10 +44,10 @@ $(JKMETER_O):
 install:	all
-	/usr/bin/install -d $(PREFIX)/bin
-	/usr/bin/install -m 755 jkmeter $(PREFIX)/bin
-	/usr/bin/install -d $(SHARED)/jkmeter
-	/usr/bin/install -m 644 ../share/* $(SHARED)/jkmeter
+	/usr/bin/install -d $(DESTDIR)$(PREFIX)/bin
+	/usr/bin/install -m 755 jkmeter $(DESTDIR)$(PREFIX)/bin
+	/usr/bin/install -d $(DESTDIR)$(SHARED)/jkmeter
+	/usr/bin/install -m 644 ../share/* $(DESTDIR)$(SHARED)/jkmeter
 	/bin/rm -f *~ *.o *.a *.d *.so
pkg-multimedia-maintainers mailing list

Reply via email to