On Thu, Jul 15, 2010 at 01:39:59PM -0400, Felipe Sateler wrote:
On 15/07/10 08:26, Jonas Smedegaard wrote:
On Thu, Jul 15, 2010 at 10:20:51AM +0000,
adiknoth-gu...@users.alioth.debian.org wrote:
   Force regeneration of configure from configure.ac


+post-patches::
+    autoreconf -fi

Beware that above only ensures the autoreconf rule gets invoked after post-patches, not that it gets invoked before other later rules, which most likely you should ensure too.

Also, above does not maintain build-dependencies on autotools.

And it does not preserve the old autobuilt files so "debuild clean" won't properly clean (i.e. git will complain if building in git).

Have a look at sugar-toolkit-0.88 for a packaging example handling autoreconf using CDBS, or kannel-sqlbox for a packaging example also properly cleaning up after itself.

I object to the approach in sugar-toolkit-0.88. It is overly complicated. I think making use of dpkg-source is better: just remove the files on clean, and dpkg-source will ignore them. The kannel-sqlbox approach is better: moving files out of the way pre-build and restore them on clean (which is what we do in csound too).

Looking closer, I fully agree!

sugar-toolkit-0.88 approach is for *optionally* recreating autotools and then ficating as a patch. That approach won't even work with source format 3.0 due to patches being applied in less controllable order (autotools are quite picky about timestamps).

Thanks for spotting it, Felipe. I must drop those routines from sugar-toolkit-* (they are unneeded currently anyway).

kannel-sqlbox, on the other hand, is relatively recently packaged from scratch, so should be sane :-)


 - Jonas

--
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Attachment: signature.asc
Description: Digital signature

_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers

Reply via email to