On Fri, 2010-08-13 at 14:43 -0400, Felipe Sateler wrote: > On 13/08/10 14:12, Hans-Christoph Steiner wrote: > > > > Now that there is a separate thread on cdbs vs dh, perhaps someone could > > give me some feedback on my pd-motex package which happens to use dh. > > I'm ready to fix whatever needs fixing.
First off, thanks for the feedback, quite useful! I've also applied these changes to the other packages I ITP'ed. > THe changelog mentions that it is a non-maintainer upload. That is > certainly an error. Removed. > Make sure that the names in debian/control and > debian/changelog are byte-for-byte identical. They were as far as I could tell, did you see a difference? > Also, as we are a team, we set the maintainer field to the list, and > your own name as Uploaders. Done. > The descriptions formatting is a bit ugly, and you might want to use > double space before each element of the list of math functions (to > preserve formatting). fixed. > The short description should give an indication of what the externals do. Some of these old Pd libraries are random grabbags of things that are just collections created by the same author. > Also, somewhere in the description should the pd name be expanded into > puredata (for people searching for puredata and people not knowing what > pd is). done. > For debian/copyright.. has motex really been untouched since 2001? Besides the random little build tweaks I've done, yes. I added myself to the copyright file just to make it clear. I consider my work on these libs to be public domain. > The example should go into /usr/share/doc/pd-motex/examples. The 'examples' folder is part of the standard library format for Pd libraries, so it needs to be in the library. A .pd file is something like a .svg or a .ps: it is a text file, but its not human readable/editable in a useful way. Really a .pd file is more like a binary like .elc or .pyc than a text file. So I am not sure it is so useful in the /usr/share/doc/pd-motex/examples directory. Also, Pd users will expect the examples to show up in the Pd library browser. Do you think it would be useful to make /usr/share/doc/pd-motex/examples a link to the examples in the library folder? > Similar to the discussion on pd-zexy, is something needed to use motex? > If so, you should document that in README.Debian. The instructions in pd-zexy/README.Debian are not Debian-specific and nothing about the Debian packages require users to load libraries differently than on other platforms. IMHO, Pd users are better off using the official Pd docs on how to load libraries rather than maintaining many different README files for each library that can easily get out of date. .hc _______________________________________________ pkg-multimedia-maintainers mailing list firstname.lastname@example.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers