On Thu, Aug 19, 2010 at 10:03:22PM +0200, IOhannes m zmoelnig wrote:
i manually fixed the FIXMEs and pushed.
so i guess we are almost there.

Indeed we are.

I finalized the packaging and uploaded to the NEW queue, where it is now waiting for ftpmasters to (hopefully) approve it.

I did spot a few details during compilations, though, whcih I'd like to discuss if they are relevant to improve for future releases:

There are a few warnings like this:

  rawprint.c:45: warning: format '%X' expects type 'unsigned int', but argument 
4 has type 'struct t_gpointer *'

This might cause problems on architectures where int is of "unusual" size, if I understand it correctly.

Apparently the following compile options are used:

  -g -O2 -g -Wall -O2 -mms-bitfields -fPIC -mfpmath=sse -msse -g -O2 -g -Wall 

This indicates that default compile options in upstream source is not overridden by CFLAGS declared by packaging which is generally bad (and a Policy violation, I believe - but too lazy to look it up right now), and especially may hurt emdebian and similar andvanced users depending on being able to override CFLAGS during packaging build time.

More specifically, the upstream defaults include sse which I believe makes the resulting code require an i586 or even an i686 class machine. I did not look closer and this might simply be due to this compilation happening on amd64 which always has this instruction set. Just mentioning in case upstream assumes newer grades x64: Debian assumes i486.

Also, some archs have problems with fPIC, and I believe it is mentioned in Debian Policy that normal builds should *not* use fPIC while static libraries (unused here, just mentioning for completenes sake) *should* use it.


- Jonas

 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Attachment: signature.asc
Description: Digital signature

pkg-multimedia-maintainers mailing list

Reply via email to