On Tue, Aug 17, 2010 at 18:08:39 (CEST), Thomas Maass wrote:

> http://mentors.debian.net/debian/pool/main/c/clipgrab

- debian/changelog: misses ITP bugnumber:

W: clipgrab: new-package-should-close-itp-bug
N:    This package appears to be the first packaging of a new upstream
N:    software package (there is only one changelog entry and the Debian
N:    revision is 1), but it does not close any bugs. The initial upload of a
N:    new package should close the corresponding ITP bug for that package.
N:    This warning can be ignored if the package is not intended for Debian or
N:    if it is a split of an existing Debian package.
N:    Refer to Debian Developer's Reference section 5.1 (New packages) for
N:    details.
N:    Severity: normal, Certainty: certain

- debian/clibgrab.desktop: spurious empty first line, and:

I: clipgrab: desktop-entry-contains-encoding-key 
/usr/share/applications/clipgrab.desktop:4 Encoding
N:    The Encoding key is now deprecated by the FreeDesktop standard and all
N:    strings are required to be encoded in UTF-8. This desktop entry
N:    explicitly specifies an Encoding of UTF-8, which is harmless but no
N:    longer necessary.
N:    The desktop-file-validate took in the desktop-file-utils package is
N:    useful for checking the syntax of desktop entries.
N:    Refer to
N:    http://standards.freedesktop.org/desktop-entry-spec/1.0/apc.html for
N:    details.
N:    Severity: wishlist, Certainty: certain

- debian/clibgrab.xpm: who has created this? -> copyright missing?
- debian/control: 
   - maintainer field should point to team
   - put yourself as uploader
   - description is very terse, please elaborate
   - why is the build dependency on libstdc++6-4.4-dev necessary?
     (at least the version looks suspicious)
- debian/copyright: don't copy the complete GPLv3 text there, please
  refer to the copy in usr/share/common-licenses. see how other packages
  write them.

E: clipgrab: copyright-should-refer-to-common-license-file-for-gpl
N:    The strings "GNU General Public License" or "GPL" appear in the
N:    copyright file for this package, but the copyright file does not
N:    reference /usr/share/common-licenses as the location of the GPL on
N:    Debian systems.
N:    If the package uses some other license that just mentions the GPL and
N:    that Lintian should detect as an exception, please file a Lintian bug.
N:    If the copyright file must mention the GPL for reasons other than
N:    stating the license of the package, please add a Lintian override.
N:    Refer to Debian Policy Manual section 12.5 (Copyright information) for
N:    details.
N:    Severity: important, Certainty: possible

- debian/patches/01_clibgrab.pro: misses patch documentation
- debian/rules:
    - please avoid leading spaces. all targets seem to be indented with
      4 spaces
    - use a quilt patch to patch the Makefile, avoid sed butchery
- debian/watch: spurious empty line 2

Reinhard Tartler, KeyID 945348A4

pkg-multimedia-maintainers mailing list

Reply via email to