On Sat, Oct 16, 2010 at 11:56:36AM +0200, Jonas Smedegaard wrote:
On Wed, Oct 13, 2010 at 12:27:40AM -0400, Alexandre Quessy wrote:
By the way this project is very simple for now. It contains:
* executable
* man page
* desktop file
* icon
* Debian menu entry
* copyright, readme, etc.
Anything else I should add?

Your packaging overrrides a lintian warning. Please either add a comment in there explaining why you believe that warning to be wrong, or remove the override: It is bad to silence lintian without a good reason!

I now commented out that lintian override for now. Feel free to reenable it, but please then add an explanation as noted there.

I am preparing an upload now.

I would like the following to be improved soon:

The packaging depends on a bunch of gstreamer packages and more. Are all of that *always* *crucial* for toonloop? Dependencies that toonloop can survive without for some (maybe exotic) use, should be relaxed to recommends.

Similar for build-dependencies: I noticed e.g. mencoder is a build-dependency, and that autotools check for it, but if not actually used at build time or in any tests, then I suggest improving upstream routines to distinguish between buildtime and runtime dependencies - e.g. only check for actual build dependencies in autotools and have the toonloop application check for runtime dependencies when invoked.

Thanks for your great contribution!

- Jonas

 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Attachment: signature.asc
Description: Digital signature

pkg-multimedia-maintainers mailing list

Reply via email to