Hi Loïc,

On Wed, Nov 10, 2010 at 01:23:50AM +0100, Loïc Minier wrote:
Just a heads up that I pushed a couple of patches into the git repo for the morituri package; hope you don't mind! :-)

I don't mind at all - on the contrary, your contribution is great!

But I do have suggestions for doing even better in the future:

  * Inform us via the email address in the maintainer field, rather
than (only) to me. And use the maintainer field in our VCS to ensure you get the latest one, in case it changed since last packaging release.
  * Include Bug hint in patch or at least provide a URL, instead of
    just tagging Forwarding: yes.  Even if others (i.e. me) didn't
    do it for other patches.
    More info at http://dep.debian.net/deps/dep3/
  * Follow patch naming scheme as documented in debian/patches/README.
Specifically - since you did not provide a Bug: hint - I suspect that the provided patches was cherry-picked from upstream VCS (rather than _pushed_ upstream) and thus more appropriately should
    use a leading 0, not 1.

I dare cc the Multimedia team this email.  Hope you are ok with that.

Kind regards, and thanks for your interest in Morituri,

 - Jonas

 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Attachment: signature.asc
Description: Digital signature

pkg-multimedia-maintainers mailing list

Reply via email to