On Wed, Nov 10, 2010 at 14:06:10 (CET), Jonas Smedegaard wrote: > On Wed, Nov 10, 2010 at 11:55:55AM +0100, Reinhard Tartler wrote: >>On Wed, Nov 10, 2010 at 09:21:17 (CET), IOhannes m zmoelnig wrote: >> >>> On 2010-11-09 22:51, Felipe Sateler wrote: >>> >>>>> pd-pan >>>> >>>> Please update the changelog when updating the package. The timestamp >>>> helps people tell when was the last time someone worked on a >>>> package. Also the long description is too short >>>> >>> >>> hmm, this confuses me a bit. >>> i thought that the changelog should not be touched until the upload, >>> and only the person uploading would then run git-dch to regenerate >>> the changelog from the commit-messages (and eventually cleanup). >> >> You can greatly help the person reviewing the upload by running >> git-dch at the point where you think the package is ready for upload, >> i.e., you think the package is in a state that you would have uploaded >> yourself if you had upload priviledges. >> >> Of course the actual upload might want to do some additional changes >> or spots mistakes. In that case he has to update the changelog in a >> seperate commit, but that's not really a problem. > > I suspect (but must admit that I haven't closely read our wiki pages > lately) that we have no clear rules about this. > > I propose the following: > > * As a minimum, the changelog is completely untouched until final > release, where the uploader auto-generates using "git-dch -R", adjusts > by hand as needed, and commits the changes.
"completely untouched" is too strong, I think. Please put at least a dummy changelog entry "start new upload" or something with the correct version number, so that test builds end up with the correct version number. This makes testing easier. > * Optionally intermediate updates to the changelog can be applied. > Begin with "git-dch" and if that fails then instead use > "git-dch --since <REF>" (replacing <REF> with reference to last > commit that touched debian/changelog), set distribution to > UNRELEASED, and commit the changes. > * Intermediate changelog updates are encouraged when release is > expected only later, and when more people work on same package. > > > In other words, I propose to replace the earlier commit style > (documented in the wiki?) of unconditionally adding UNRELEASED [ "with the procedure above" is missing, I assume ] > - which does not work optimally together with git-dch IMO. YMMV, but I think what you describe works well enough with git-dch. otherwise, looks good to me. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 _______________________________________________ pkg-multimedia-maintainers mailing list firstname.lastname@example.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers