Hi Alessandro, hi Paul, and thanks for the review!
On Tue, Dec 7, 2010 at 12:22 AM, Paul Tagliamonte <paul...@ubuntu.com> wrote: > At first glance, it seems like you're newlining a bit too much on the > control deps. It's valid, and better then a single line, but see if > you can hit under 80, and get more then one to a line. Helps cut out > some scrolling ( and you can check all the deps in a terminal :) Agreed, please keep lines shorter than 80 chars. > Your description is great, but way-y-y-y-y long :) Oh no, many packages have so less descriptive and very short descriptions, would you blame him for that? :))) Anyway, I'd shorten the features list just a bit. > P: deadbeef: no-upstream-changelog Easy to fix: override_dh_installchangelogs: dh_installchangelogs -pdeadbeef ChangeLog > X: deadbeef-plugins: shlib-calls-exit usr/lib/deadbeef/alsa.so.0.0.0 It's a common mistake, it had better report this to upstream. > 0.4.4~dfsg-1 might be better phrased as 0.4.4-1~dfsg1 Upstream version number changes from 0.4.4 to 0.4.4~dfsg due to the repacking, hence appending ~dfsg to the end of 0.4.4 is correct. > install should be deadbeef.install > docs should be deadbeef.docs Although unnecessary, these improve the readibility. > menu should be deadbeef.menu Not needed. > manpages should be deadbeef.manpages Maybe needed, I should check. There is a number of subdirectories under plugins/ and some of them seem to contain components already available in Debian. I've found the following ones: plugins/ mms/ musepack/ We should rely on the libraries provided by the system rathen than bring, compile and link against local copies. See you guys, and buonanotte! -- Alessio Treglia | www.alessiotreglia.com Debian Developer | ales...@debian.org Ubuntu Core Developer | quadris...@ubuntu.com 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0 _______________________________________________ pkg-multimedia-maintainers mailing list firstname.lastname@example.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers