On Mon, Dec 06, 2010 at 06:22:29PM -0500, Paul Tagliamonte wrote:
> At first glance, it seems like you're newlining a bit too much on the
> control deps. It's valid, and better then a single line, but see if
> you can hit under 80, and get more then one to a line. Helps cut out
> some scrolling ( and you can check all the deps in a terminal :)

It felt awkward to me too. Ii is now 3/4 deps per line under 80 chars.

> Your description is great, but way-y-y-y-y long :)

I've just copied it from upstream. Btw I deleted some entries in the 
features list. I left the IMHO most important. 
Don't know if this is enough.

> You have a few non-critical errors on your debs:
> P: deadbeef: no-upstream-changelog
> P: deadbeef-plugins: no-upstream-changelog
> X: deadbeef-plugins: shlib-calls-exit usr/lib/deadbeef/alsa.so.0.0.0
> X: deadbeef-plugins: shlib-calls-exit usr/lib/deadbeef/dca.so.0.0.0
> X: deadbeef-plugins: shlib-calls-exit usr/lib/deadbeef/gtkui.so.0.0.0
> X: deadbeef-plugins: shlib-calls-exit usr/lib/deadbeef/notify.so.0.0.0
> X: deadbeef-plugins: shlib-calls-exit usr/lib/deadbeef/sid.so.0.0.0
> X: deadbeef-plugins: shlib-calls-exit usr/lib/deadbeef/vtx.so.0.0.0
> P: deadbeef-plugins-dev: no-upstream-changelog

Fun fact, I don't get those errors even with lintian -I -E --pedantic (I 
run it on the .changes file).
For example when I build the packages the upstream changelog is correctly 
installed in every package under usr/share/doce/...

Maybe I'm doing something wrong :/

> 0.4.4~dfsg-1 might be better phrased as 0.4.4-1~dfsg1

I've done what Jonas said. See [0] :)

> install should be deadbeef.install
> menu should be deadbeef.menu
> manpages should be deadbeef.manpages
> docs should be deadbeef.docs

Done, including what Alessio said.

Thank you very much for the review. I re-uploaded the package.


perl -E'$_=q;$/= @{...@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'

pkg-multimedia-maintainers mailing list

Reply via email to