On Thu, Feb 10, 2011 at 08:52, IOhannes m zmoelnig <zmoel...@iem.at> wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 2011-02-09 21:37, Felipe Sateler wrote: > > > > Cloning the git repository and running git-buildpackage will result in > > the following error: > > thanks for trying. > > > > I've not seen this kind of behavior in the other pd packages, I > > presume because the Makefile fiddles with CFLAGS (which it shouldn't), > > and CDBS sets a default value for them (dh doesn't, which might > > explain why this issue appears here). > > > > indeed that is the reason (upstream uses a different (and more > complicated build system) than most of the Pd externals you might have > seen so far, that's why you haven't seen the problem before...) > > anyhow, i (hopefully) fixed it (and noticed some causes FTBFS for > non-linux builds, which i fixed as well) and pushed.
Please split the patch into several, one for each fix. It makes it easier to review. Also, the fix for CFLAGS/LDFLAGS is not completely correct: it ignores the CFLAGS/LDFLAGS passed by the user, is that intentional? If so, please document why. -- Saludos, Felipe Sateler _______________________________________________ pkg-multimedia-maintainers mailing list firstname.lastname@example.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers