On 02/19/2011 10:05 PM, Fabian Greffrath wrote:
Dear Hans,

could you please comment on this? I'd like to backport this patch from
trunk to the version in Debian squeeze (libmms 0.6), because it is known
to fix the alignment bug on ARM, see

Oh, good catch. So the story goes like this, indeed the SAME_ENDIAN
and SWAP_ENDIAN macros should be called LITTLE_ENDIAN_TO_NATIVE resp.
BIG_ENDIAN_TO_NATIVE, iow they indeed will do the wrong thing
on bigendian if used as intended, but the WORDS_BIGENDIAN
define which is checked for does not get defined by standard
C headers, so we end up using the "/* Little endian */" block
on big endian machines too. So this is a case were 2 wrongs
make a right.

I'll change this (really fix it) in git soonish, likely tomorrow.

BTW, note that I strongly believe that the 0.6.1 and 0.6.2 releases
are bugfix only releases, fixing a number of small but nice to
have fixed bugs. Ok I must admit that the ipv6 changes could be called
a feature, then again not supporting ipv6 now a days can also plainly
be called a bug. So I think it would be best to just rebase the packages
to 0.6.2, rather then do a backport.



pkg-multimedia-maintainers mailing list

Reply via email to