Dear Xvid devs,

first, let me congratulate you to the 1.3.0 release.

However, I've found issues with your usage of autoconf in the build/generic directory:

1) The files config.guess and config.sub in this directory are *ancient* (they date back to 2003) and should really get replaced by more current ones. They are available e.g. here:
<http://savannah.gnu.org/projects/config>

2a) The configure script has been created with an ancient version (2.59) of autoconf, which also dates back to 2003. Please regenerate it with a current version of autoconf.

2b) But then, the configure.in template for autoconf contains a syntax error that makes the generated configure script generate faulty code. Please find a simple patch attached or (in case it gets mangled) here:
<http://git.debian.org/?p=pkg-multimedia/xvidcore.git;a=blob;f=debian/patches/configure.in-fix.patch>

Best regards,
Fabian

Patch to fix issue where autoconf outputs badly formatted configure script
==========================================================================
--- xvidcore.orig/build/generic/configure.in
+++ xvidcore/build/generic/configure.in
@@ -593,13 +593,13 @@ dnl
 dnl ==========================================================================
 
 AC_CHECK_HEADER(
-	pthread.h,
-	AC_CHECK_LIB(
-		pthread,
-		pthread_create,
-		SPECIFIC_CFLAGS="$SPECIFIC_CFLAGS -DHAVE_PTHREAD"
-		SPECIFIC_LDFLAGS="$SPECIFIC_LDFLAGS -lpthread",
-		AC_MSG_WARN(Pthread not supported. No SMP support)),
+	[pthread.h],
+	[AC_CHECK_LIB(
+		[pthread],
+		[pthread_create],
+		[SPECIFIC_CFLAGS="$SPECIFIC_CFLAGS -DHAVE_PTHREAD"
+		 SPECIFIC_LDFLAGS="$SPECIFIC_LDFLAGS -lpthread"],
+		AC_MSG_WARN(Pthread not supported. No SMP support))],
 	AC_MSG_WARN(Pthread not supported. No SMP support))
 
 dnl ==========================================================================
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers

Reply via email to