Hello, On antradienis 01 Kovas 2011 08:06:18 Pedro Lopez-Cabanillas wrote: > You are wrong assuming that the variable QT_X11_X11_LIBRARY is deprecated > in CMake 2.8.1, or it is not available anymore. The CMake macros were > reorganized, and now this variable is set in > Qt4ConfigDependentSettings.cmake  (lines 259-271) which is included > from FindQt4.cmake , line 1035, and it is also documented . > > The attached CMakeLists.txt test file should work as expected. Here is the > output in my development machine: $ cmake . > -- The C compiler identification is GNU > -- The CXX compiler identification is GNU > -- Check for working C compiler: /usr/bin/gcc > -- Check for working C compiler: /usr/bin/gcc -- works > -- Detecting C compiler ABI info > -- Detecting C compiler ABI info - done > -- Check for working CXX compiler: /usr/bin/c++ > -- Check for working CXX compiler: /usr/bin/c++ -- works > -- Detecting CXX compiler ABI info > -- Detecting CXX compiler ABI info - done > -- Looking for Q_WS_X11 > -- Looking for Q_WS_X11 - found > -- Looking for Q_WS_WIN > -- Looking for Q_WS_WIN - not found. > -- Looking for Q_WS_QWS > -- Looking for Q_WS_QWS - not found. > -- Looking for Q_WS_MAC > -- Looking for Q_WS_MAC - not found. > -- Found Qt-Version 4.6.3 (using /usr/bin/qmake) > -- Looking for _POSIX_TIMERS > -- Looking for _POSIX_TIMERS - found > -- QT_X11_X11_LIBRARY contains: /usr/lib/libX11.so > -- Configuring done > -- Generating done
I don't see anything in the code you referred to which would define QT_X11_X11_LIBRARY variable. If anything it shows that X11_X11_LIB is being used. > > You're right that current debian patch (courtesy by ubuntu) is a pure > > hack and you nailed its deficiencies well. But you have the bug on your > > hands nevertheless, it's not debian-specific bug. In order to fix this > > properly, do find_package(X11) and use a proper variable which expands > > to X11 library (iirc, X11_X11_lib). > > I don't agree with that. You are proposing to patch this package, but every > build system depending on CMake and the variable QT_X11_X11_LIBRARY would > need a similar patch. Won't be better a common solution that works for all > of them? In my opinion it would be preferred to patch Debian's CMake > package. Oh please. Debian DOES NOT patch cmake in this Qt4 code or anything remotely related. Period. We actively push cmake patches upstream and our 2.8.4 is an almost pure vanilla version with a couple of minor changes now. QT_X11_X11_LIBRARY was removed in favour of X11_X11_LIB and that's how it is (I don't feel like chasing when). Just get over it. I feel like you are not listening, but it's your right. So until you wake up, Debian maintainer will have to patch libdrumstick. However, I just suggest him doing s/QT_X11_X11_LIBRARY/X11_X11_LIB/ instead of current patch-hack that is of really poor quality and has some bad side effects. Sorry for a bit rude tone, but I really feel that I spent more time on this I have on my hands. Such a long debate for a single variable? Uch... -- Modestas Vainius <mo...@debian.org>
Description: This is a digitally signed message part.
_______________________________________________ pkg-multimedia-maintainers mailing list firstname.lastname@example.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers