On Thu, Apr 07, 2011 at 05:23:03PM +0700, Артём Попов wrote:
> Hello,

Hi Artem,

> My name's Artem and I'd like to join the Debian Multimedia Maintainers
> team. I've brought two packages that I'd like to co-maintain with the
> team, they are described below. Of course, I'd love to help with other
> packages in the future. My alioth account is "artfwo-guest" and I have
> a little packaging experience by now (about 20 sponsored uploads for
> Ubuntu).

That's great. If you haven't already done this, please have a look at our 
policies [0] (e.g. using git to team maintain packages, quilt for patches, 
etc...). If you agree with them I (or someone else) will add you to the 
alioth project.

> The packages, which I intend to maintain are boodler (new) and adplug
> (orphaned), I'm a heavy user of both. I would be glad if someone from
> the Debian multimedia team could review and integrate them into
> git.debian.org repository. Thanks!

Just had a quick look at your packages (please note that I'm not a DD, so I
can't upload them for you, but you'll find someone from the team to do it).

> Boodler:
> 
> - URL: http://mentors.debian.net/debian/pool/main/b/boodler
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget 
> http://mentors.debian.net/debian/pool/main/b/boodler/boodler_2.0.4-1.dsc
> 
> ITP, binaries:
> http://mentors.debian.net/cgi-bin/sponsor-pkglist?action=details;package=boodler
> 
> Discussion on debian-mentors:
> http://lists.debian.org/debian-mentors/2011/03/msg00095.html

Looks mostly clean, just a few points:
- There's a bit of mess in debian/copyright :)
  ~ The LGPL-2+ is repeated twice. You need just one "License: LGPL-2+"
  section, and then you can use it from the various "Files: ..." (yes, I'm
  talking about the "Files: *" section).
  ~ You have to put a "." (dot) between different paragraphs in the same 
  field, e.g.:

   This library is free software; you can redistribute it and/or
   modify it under the terms of the GNU Library General Public
   License as published by the Free Software Foundation; either
   version 2 of the License, or (at your option) any later version.
   .
   This library is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
   Library General Public License for more details.
   [...]

  and not:

   This library is free software; you can redistribute it and/or
   modify it under the terms of the GNU Library General Public
   License as published by the Free Software Foundation; either
   version 2 of the License, or (at your option) any later version.

   This library is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
   Library General Public License for more details.

 (this makes automatic parsing of the file much easier)

 ~ You also don't need the "(C)" in the Copyirght fields.
 ~ Note that src/cboodle/audev-lame.c is licensed GPL-2+, and not LGPL-2+.
- There are some lintian warnings you may want to look at:

W: boodler: description-synopsis-starts-with-article
I: boodler-alsa: package-contains-empty-directory usr/share/pyshared/boodle/

(and many others similar). 

To fix the various description-synopsis-starts-with-article, you may decide 
to change the short description from "A programmable soundscape tool" to 
just "Programmable soundscape tool".

> Adplug:
> 
> - URL: http://mentors.debian.net/debian/pool/main/a/adplug
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget 
> http://mentors.debian.net/debian/pool/main/a/adplug/adplug_2.2.1+dfsg1-1.dsc
> 
> ITP, binaries:
> http://mentors.debian.net/cgi-bin/sponsor-pkglist?action=details;package=adplug

- Again, there is some mess in d/copyright. You should IMHO list verbatim
copies of the licenses (GPL-3+, LGPL-2.1+, ...)
- The package libadplug-dev is installing a *.la file. One of the old 
release goals for Squeeze was the complete removal of unneeded la files [1].
If you think that file is actually required (which, probably, is not the 
case), leave it there, otherwise please remove it.
- Since adplug uses autotools to build, please use the autotools-dev plugin
for debhelper (provided by the homonym package) to build (you just have to
add "--with autotools-dev" in debian/rules and "autotools-dev" to 
Build-Depends). That will automatically upgrade the config.{sub,guess} files
during build, restoring the originals after the build is complete.
- It may be nice to provide a *.symbols file for the library. See "man 
dpkg-gensymbols".
- It may be also a good idea to document (e.g. in debian/copyright) which
files have been removed due to missing "DFSG-compliantness" and also provide
a "get-orig-source" rule in debian/rules, to help automatic repackaging.

Cheers

[0] http://wiki.debian.org/DebianMultimedia/DevelopPackaging
[1] http://wiki.debian.org/ReleaseGoals/LAFileRemoval

-- 
perl -E'$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'

_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers

Reply via email to