Hi Robin, On 11-04-18 at 07:29pm, Robin Gareus wrote: > I've added config-templates and postinst configuration (passwords, > hostname, enable-service) to icecast2.
Nice! > Attached patch applies to revision baf67ba (currently HEAD) on > http://git.debian.org/?p=pkg-multimedia/icecast2.git > > What would be needed to get this into the official icecast2 debian > package? Please open a bugreport against the package and include the patch there. Also, it seems to me from briefly reading it, that you (briefly) expose passwords to all local users by printing it as part of an ed command. That is (if correctly read) a security flaw and should be avoided. One way to avoid it is to export the passwords as environment variables and then run a short perl script which uses those same variables. Like this (from a CipUX routine): export pw="bla" perl -i -pe "s/[ \t]*#([ \t]*password[ \t]*=).*/\$1\$ENV{'pw'}/" file But please, instead of discussing further here, file a bugreport and let's continue the discussion there :-) Regards, - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: Digital signature
_______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
