On sab, feb 22, 2014 at 10:49:45 -0300, Felipe Sateler wrote: > On Thu, Feb 20, 2014 at 6:30 PM, Andrew Kelley <[email protected]> wrote: > > * Package name : libgroove > > Version : 3.0.6-1 > > Upstream Author : Andrew Kelley <[email protected]> > > * URL : https://github.com/andrewrk/libgroove > > * License : Expat > > Section : libs > > As I said before, groovebasin looks cool. Are you planning on uploading it > too? > > I'm interested, but a bit short on time. It might take me some time to > go over the libgroove packaging.
I'm interested too (but I seem to have missed the original email from Anrew). So, I had a quick look at the packaging and it generally looks good, but here are a few comments: * Since it requires libav10 to be built (e.g. libavutil/frame.h), you should note that in debian/control with appropriate versioned Build-Depends. Build-Depends: [...] libavcodec-dev (>= 6:10~), libavfilter-dev (>= 6:10~), libavformat-dev (>= 6:10~), libavutil-dev (>= 6:10~), [...] * While at it, there should be one Build-Depends per line, as per team policy. Build-Depends: a, b, c, d * The tarball downloaded with "uscan --download-current-version" is different from the one in the pristine-tar branch. The difference seems to be that the upstream repository contains a deps/ folder bundling the libraries needed to build it. The canonical Debian way to handle this would be to repack the upstream tarball removing the directories (which is what you did) but also providing an automated way to do that. This is usually done by adding a "get-orig-source" target to debian/rules that downloads the tarball using uscan, unpacks it, rm -rf the folder and repacks it. Another way would be [0]. See Developer's Reference ยง6.7.8.2. (I'm not quite sure if the team's packaging policy says anything about this). [0] http://pkg-perl.alioth.debian.org/howto/repacking.html * The file downloaded by uscan gets called "<libgroove>-3.0.6.tar.gz" instead of "libgroove-3.0.6.tar.gz" (not really a problem but it's kinda ugly). * Any reason why you are using "version=2" instead of "version=3" in debian/watch? * The comments in debian/rules added by dh_make should be removed. * It'd be nice if you also provided *.symbols files for all the libraries built, see dpkg-gensymbols(1). * It'd be nice if you provided -dbg packages for all the libraries built (or a single -dbg for all the libraries). This should be done e.g. by overriding dh_strip and calling it like "dh_strip --dbg-package=libgroove3-dbg". That's all I think, but I may still have missed something. Feel free to ask if you have any question. Cheers -- perl -E '$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'
signature.asc
Description: Digital signature
_______________________________________________ pkg-multimedia-maintainers mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
