Your message dated Mon, 24 Feb 2014 15:44:20 +0000
with message-id <e1whxhd-0003a8...@franck.debian.org>
and subject line Bug#730415: fixed in tsdecrypt 10.0-2
has caused the Debian Bug report #730415,
regarding tsdecrypt uses inappropriate build flags including -march=native
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
730415: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=730415
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: tsdecrypt
Severity: serious
Tags: patch
Version: 8.0-1
tsdecrypt's build system appears to assume that the package is being
built with the intention of running it on the same machine it is being
built on. As such it uses -march=native and depending on detection code
sets several other flags.
This is not appropriate for debian. Packages built on debian should run
on the minimum hardware chosen by the port maintainers regardless of the
hardware in the machine used to build them. In general the porters
descisions will be reflected in the defaults that are hardcoded into the
compiler, Therefore compiler flags that affect the CPU requirements
should generally only be used to build secondary versions of code for
use in conjunction with runtime CPU detection. -march=native should
never be used as it leads to build results that depend on what hardware
happens to be in the build system.
It appears that this impacts all versions from 8.0-1 to 10.0-1
The attatched debdiff should fix this. I also included a fix for
incomplete cleanup in the clean target which I noticed while working on
the fix.
No intent to NMU.
diff -Nru tsdecrypt-10.0/debian/changelog tsdecrypt-10.0/debian/changelog
--- tsdecrypt-10.0/debian/changelog 2013-10-03 14:55:24.000000000 +0000
+++ tsdecrypt-10.0/debian/changelog 2013-11-24 19:46:41.000000000 +0000
@@ -1,3 +1,10 @@
+tsdecrypt (10.0-1+rpi1) jessie-staging; urgency=low
+
+ * Remove inappropriate compiler flags.
+ * fix clean target
+
+ -- Peter Michael Green <plugw...@raspbian.org> Sun, 24 Nov 2013 19:39:56
+0000
+
tsdecrypt (10.0-1) unstable; urgency=low
* New upstream release:
diff -Nru tsdecrypt-10.0/debian/patches/avoid-inappropriate-compiler-flags
tsdecrypt-10.0/debian/patches/avoid-inappropriate-compiler-flags
--- tsdecrypt-10.0/debian/patches/avoid-inappropriate-compiler-flags
1970-01-01 00:00:00.000000000 +0000
+++ tsdecrypt-10.0/debian/patches/avoid-inappropriate-compiler-flags
2013-11-24 19:39:19.000000000 +0000
@@ -0,0 +1,52 @@
+Description: Avoid inappropriate compiler flags
+ The tsdecrypt build system tries to be too clever and assumes that the system
+ it is built on will be the system it is going to run on. This is
inappropriate
+ for Debian so we need to disable some of this logic.
+Author: Peter Michael Green <plugw...@debian.org>
+
+--- tsdecrypt-10.0.orig/FFdecsa_init
++++ tsdecrypt-10.0/FFdecsa_init
+@@ -106,26 +106,26 @@ test_ffdecsa_mode() {
+ }
+
+ # Check CPU and compiler flags
+-if cc_check -march=native
+-then
+- FFDECSA_CFLAGS="$FFDECSA_CFLAGS -march=native"
+-elif cc_check -march=pentium; then
+- FFDECSA_CFLAGS="$FFDECSA_CFLAGS -march=pentium"
+-fi
++#if cc_check -march=native
++#then
++# FFDECSA_CFLAGS="$FFDECSA_CFLAGS -march=native"
++#elif cc_check -march=pentium; then
++# FFDECSA_CFLAGS="$FFDECSA_CFLAGS -march=pentium"
++#fi
+
+ OPTS=""
+ FLAGS=""
+-for flag in mmx sse sse2
+-do
+- if cpu_have $flag
+- then
+- OPTS="$OPTS $flag"
+- if cc_check -m$flag
+- then
+- FFDECSA_CFLAGS="$FFDECSA_CFLAGS -m$flag"
+- fi
+- fi
+-done
++#for flag in mmx sse sse2
++#do
++# if cpu_have $flag
++# then
++# OPTS="$OPTS $flag"
++# if cc_check -m$flag
++# then
++# FFDECSA_CFLAGS="$FFDECSA_CFLAGS -m$flag"
++# fi
++# fi
++#done
+
+ log "Host CPU" "$(uname -m) $OPTS"
+ log "FFdecsa CFLAGS" "$FFDECSA_CFLAGS"
diff -Nru tsdecrypt-10.0/debian/patches/series
tsdecrypt-10.0/debian/patches/series
--- tsdecrypt-10.0/debian/patches/series 1970-01-01 00:00:00.000000000
+0000
+++ tsdecrypt-10.0/debian/patches/series 2013-11-24 19:37:03.000000000
+0000
@@ -0,0 +1 @@
+avoid-inappropriate-compiler-flags
diff -Nru tsdecrypt-10.0/debian/rules tsdecrypt-10.0/debian/rules
--- tsdecrypt-10.0/debian/rules 2013-10-03 14:55:12.000000000 +0000
+++ tsdecrypt-10.0/debian/rules 2013-11-24 19:46:24.000000000 +0000
@@ -20,3 +20,7 @@
mkdir -p $(DESTDIR)$(PREFIX)/bin
install tsdecrypt_ffdecsa tsdecrypt_dvbcsa \
$(DESTDIR)$(PREFIX)/bin
+
+override_dh_auto_clean:
+ dh_auto_clean
+ rm -f FFdecsa_build_PARALLEL_*.log
\ No newline at end of file
--- End Message ---
--- Begin Message ---
Source: tsdecrypt
Source-Version: 10.0-2
We believe that the bug you reported is fixed in the latest version of
tsdecrypt, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 730...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Alessio Treglia <ales...@debian.org> (supplier of updated tsdecrypt package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Mon, 24 Feb 2014 14:52:09 +0000
Source: tsdecrypt
Binary: tsdecrypt
Architecture: source amd64
Version: 10.0-2
Distribution: unstable
Urgency: low
Maintainer: Debian Multimedia Maintainers
<pkg-multimedia-maintainers@lists.alioth.debian.org>
Changed-By: Alessio Treglia <ales...@debian.org>
Description:
tsdecrypt - decrypt MPEG transport stream
Closes: 730415
Changes:
tsdecrypt (10.0-2) unstable; urgency=low
.
[ Peter Michael Green ]
* Remove inappropriate compiler flags. (Closes: #730415)
* Fix clean target.
.
[ Alessio Treglia ]
* Bump Standards.
Checksums-Sha1:
a0f42ac7d9b0b94a735bc18dc8826da6312d4757 1991 tsdecrypt_10.0-2.dsc
168eb87f9d6a4a1729d8c7ac98d9161c59bb469d 4998 tsdecrypt_10.0-2.debian.tar.gz
bd077bb4b442b3e42966b3eec63216efab3109bf 116616 tsdecrypt_10.0-2_amd64.deb
Checksums-Sha256:
2ddb1da0f78be7d288f39743c21837ef397a44dc24ed81d13cac4b62c2a4bbb2 1991
tsdecrypt_10.0-2.dsc
60809ff451a37a135249a0fdacd8f140591456f2d76c8b3d1a40c4fa409dfade 4998
tsdecrypt_10.0-2.debian.tar.gz
b8924e3c4da443150e942d3ba6a755bcc698a0fa92945db6a548a1c6684061f0 116616
tsdecrypt_10.0-2_amd64.deb
Files:
2925730f2bd17d2301cb4aa0a0c8fa7e 1991 video optional tsdecrypt_10.0-2.dsc
4e198613c82741e193485ea5244e1388 4998 video optional
tsdecrypt_10.0-2.debian.tar.gz
292c5afe77cf631b21544cea78233c1e 116616 video optional
tsdecrypt_10.0-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBAgAGBQJTC10yAAoJEOikiuUxHXZaVtAQAIhhwK8vG4e4dP7maTu5+u21
m8d9ZqCiIDXC7SBmM/cmhMZGdIANRFPpPzPw82b52CWW5hXd2r/YVt21are8UZvn
CiKjZKMM0EVeTfvOhh7S04mKTgdnNpfpcQ25zgcLliKfYSjaCnhbaCTzJWkbml4L
OVLiyqM5Kr1Vk8JjIwPLYe1rZiGrddQKGOpPCT/O2pLGrD68hZrePSRUh4ktR6Ye
ZfrKLjoaSqGltFhR2kH8eys9C8qFfzJOZSt8yLeJWJ0uBLeCcdLCXDFFwvF3kBGT
mGqPaqg8GFQeRlYl+yW9z7ZnTLapquzdYhboh5Sr9lZhvGE0v+4+lw6X8Jyfkfmi
JhjO1tQE9ElRY92ejpkRKx36z6mOcscHwn1uDC1o06OkfX14fSub8uRbuiCf8Nti
e2SW9lj18klPbCMZQRMGce5MZ6HuKabhK7IagfjQzgbpd7XRNn758NjElAfKZluC
2e9XVWM8Aw/fhn5odOWPch79X+XHygHOHS5PZ03AX8zVSB2pXu87lhwHAb2z8ORy
0JuzW+MIb1UL1og/ktyDVK9nYUvBtS8bd87BMrrc30rIbzJ4QUAuMWoL+sJ4FwQn
b7G3Jq0v0zrBlVw2Bi33mq8UMDKCehdjYNxmWKHFQtiJY1YvpK8+wfFZt7C0SsIx
KI0Z65ojJ0FD/gZzHwY1
=MyWE
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
