Your message dated Sun, 28 Jun 2015 18:19:06 +0000
with message-id <[email protected]>
and subject line Bug#783879: fixed in gpac 0.5.2-426-gc5ad4e4~dfsg4-1
has caused the Debian Bug report #783879,
regarding gpac: stop relying on private libavformat defines
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
783879: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=783879
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: gpac
Version: 0.5.0+svn5324~dfsg1-1
Severity: important
Dear maintainer,
the gpac version currently in unstable relies on FF_API_CLOSE_INPUT_FILE
being defined in the avformat.h header. However this is a private define,
since it starts with FF_ and not with AV_.
Therefore it can be removed at any time without being considered an API
break. This has happened in FFmpeg 2.5 (and Libav git master).
Attached patch fixes this. It is based on upstream changes, with one
additional change. Upstream uses:
#ifndef FF_API_CLOSE_INPUT_FILE
#define FF_API_CLOSE_INPUT_FILE 1
#endif
However the define in libavformat was:
#ifndef FF_API_CLOSE_INPUT_FILE
#define FF_API_CLOSE_INPUT_FILE (LIBAVFORMAT_VERSION_MAJOR < 56)
#endif
This is necessary to be able to build against FFmpeg > 2.5.
Best regards,
Andreas
--- /dev/null
+++ b/debian/patches/FF_API_CLOSE_INPUT_FILE.patch
@@ -0,0 +1,54 @@
+Description: Stop relying on private libavformat defines
+
+Author: Andreas Cadhalpun <[email protected]>
+Origin: upstream, https://github.com/gpac/gpac/commit/9df6fe85aba08944ef03b610c4d5efe1aaaca578, https://github.com/gpac/gpac/commit/5f8358a17736e1cd692b7330dbe7e17ae3693a0a
+
+--- gpac-0.5.0+svn5324~dfsg1.orig/modules/ffmpeg_in/ffmpeg_demux.c
++++ gpac-0.5.0+svn5324~dfsg1/modules/ffmpeg_in/ffmpeg_demux.c
+@@ -61,6 +61,10 @@
+ #define FF_API_FORMAT_PARAMETERS 1
+ #endif
+
++#ifndef FF_API_CLOSE_INPUT_FILE
++#define FF_API_CLOSE_INPUT_FILE (LIBAVFORMAT_VERSION_MAJOR < 56)
++#endif
++
+ #endif
+
+
+@@ -314,7 +318,7 @@ static Bool FFD_CanHandleURL(GF_InputSer
+ }
+
+ exit:
+-#ifndef FF_API_CLOSE_INPUT_FILE
++#if FF_API_CLOSE_INPUT_FILE
+ if (ctx) av_close_input_file(ctx);
+ #else
+ if (ctx) avformat_close_input(&ctx);
+@@ -685,7 +689,7 @@ static GF_Err FFD_ConnectService(GF_Inpu
+
+ ffd->seekable = (av_seek_frame(ffd->ctx, -1, 0, AVSEEK_FLAG_BACKWARD)<0) ? 0 : 1;
+ if (!ffd->seekable) {
+-#ifndef FF_API_CLOSE_INPUT_FILE
++#if FF_API_CLOSE_INPUT_FILE
+ av_close_input_file(ffd->ctx);
+ #else
+ avformat_close_input(&ffd->ctx);
+@@ -704,7 +708,7 @@ static GF_Err FFD_ConnectService(GF_Inpu
+
+ err_exit:
+ GF_LOG(GF_LOG_ERROR, GF_LOG_CONTAINER, ("[FFMPEG] Error opening file %s: %s\n", url, gf_error_to_string(e)));
+-#ifndef FF_API_CLOSE_INPUT_FILE
++#if FF_API_CLOSE_INPUT_FILE
+ if (ffd->ctx) av_close_input_file(ffd->ctx);
+ #else
+ if (ffd->ctx) avformat_close_input(&ffd->ctx);
+@@ -762,7 +766,7 @@ static GF_Err FFD_CloseService(GF_InputS
+
+ ffd->is_running = 0;
+
+-#ifndef FF_API_CLOSE_INPUT_FILE
++#if FF_API_CLOSE_INPUT_FILE
+ if (ffd->ctx) av_close_input_file(ffd->ctx);
+ #else
+ if (ffd->ctx) avformat_close_input(&ffd->ctx);
diff --git a/debian/patches/series b/debian/patches/series
index 49b48c8..b61302c 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -2,3 +2,4 @@ mp4box-manpage-fix.patch
gcc-optflags.patch
libav10.patch
export_gf_isom_set_pixel_aspect_ratio.patch
+FF_API_CLOSE_INPUT_FILE.patch
--- End Message ---
--- Begin Message ---
Source: gpac
Source-Version: 0.5.2-426-gc5ad4e4~dfsg4-1
We believe that the bug you reported is fixed in the latest version of
gpac, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Balint Reczey <[email protected]> (supplier of updated gpac package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 28 Jun 2015 11:44:32 -0500
Source: gpac
Binary: gpac gpac-dbg gpac-modules-base libgpac3 libgpac-dbg libgpac-dev
Architecture: source
Version: 0.5.2-426-gc5ad4e4~dfsg4-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers
<[email protected]>
Changed-By: Balint Reczey <[email protected]>
Description:
gpac - GPAC Project on Advanced Content - utilities
gpac-dbg - GPAC Project on Advanced Content - debugging symbols
gpac-modules-base - GPAC Project on Advanced Content - modules
libgpac-dbg - GPAC Project on Advanced Content - debugging symbols for libgpac3
libgpac-dev - GPAC Project on Advanced Content - development files
libgpac3 - GPAC Project on Advanced Content - shared libraries
Closes: 776301 783879
Changes:
gpac (0.5.2-426-gc5ad4e4~dfsg4-1) unstable; urgency=medium
.
[ Alessio Treglia ]
* New upstream version 0.5.2-426-gc5ad4e4 (Closes: #776301, #783879)
* Update repacking mechanism.
The project moved to github.
* Update repack.sh
* Update compression in gbp.conf
* Refresh patches
.
[ Balint Reczey ]
* Refresh remaining patches
* Update passing revision to configure
* Don't fail the build intentionally on unknown systems
* Skip test using .swf file
* List removed files in copyright file
* Remove sourceless .swf from original tarball
* Add myself to uploaders
Checksums-Sha1:
82083d600b6f48e7c868f994062efc6a237c4f1b 2804
gpac_0.5.2-426-gc5ad4e4~dfsg4-1.dsc
193a6d9d263eec67dda36544f00a6c28d8315a10 4162628
gpac_0.5.2-426-gc5ad4e4~dfsg4.orig.tar.xz
95983eaf1bb8dfdd94c4f8b79e36da95be6cbc01 27900
gpac_0.5.2-426-gc5ad4e4~dfsg4-1.debian.tar.xz
Checksums-Sha256:
66e6d338d06f69546f7476d161fb2a7355f8aafaa04f8113e6e11d6e70f45977 2804
gpac_0.5.2-426-gc5ad4e4~dfsg4-1.dsc
e15377d155531f4f795d30d203d775d6a3fa92356e4c33796d5976f953506572 4162628
gpac_0.5.2-426-gc5ad4e4~dfsg4.orig.tar.xz
8b8da74a5334b58fb86d1a50b0666e425bfe55b10a3e9cbdc9e08da0ba55830f 27900
gpac_0.5.2-426-gc5ad4e4~dfsg4-1.debian.tar.xz
Files:
585d632c434acf646cb5a0a60f88fed5 2804 graphics optional
gpac_0.5.2-426-gc5ad4e4~dfsg4-1.dsc
aeeb25c73b4aae0971b902952aff0fb0 4162628 graphics optional
gpac_0.5.2-426-gc5ad4e4~dfsg4.orig.tar.xz
772ca1866a0ad60554d39c519477c573 27900 graphics optional
gpac_0.5.2-426-gc5ad4e4~dfsg4-1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBAgAGBQJVkDNhAAoJEPZk0la0aRp9UwIP/1S0x8wV4qlkBZRTAZL6arMK
O0Y6ISK5cNl3nfxgQyDZrI7jc58jXvObo/+RTUdmTdqAoLnQZGRBEs3bIXky3ai3
oBacOR9fjFIOOo1VXAS5ULMMuMH71bMk0f0+ND/QeShLbXHhfeMq6QDbEdisBChW
pyFQT/kXQGK4CB9tZCOfN/boYDLttp341216lcvXnTOxoV0/yy6ZwjopcDL1+JKC
Z0In0BF8ciNhTt4izNb+4whcPS/T15ksw4FDFww1cdhhVDhtJ7XzRbcLcIR2Jxt9
o2/BJlzz/Ub8X1g7bZhe4cxBUFnxjyStujDRNHt4hBMR6Yhs4CsSERRwbf+86Uo6
bk50A2P/kYM/MFYoikQkWZ8VsejehSGWbR677iFoWBhaGERkbqONjCvouxKSDRrE
CHmywkHs+mIz/nQY1CK5gPEzEi1V/7YyrE53scACYjDGvC53NCfO9+PD+PTOihiM
HAhTVExl2e3DqGKWAcOO8ck545R5eIeDVs8HD+hzYKkXglFz5YL0PNKpQkRHcWAl
nM1EvWP01NNMc5z9s1ENcJNIHk8cvRMFgERGqXg5rJfQh+NyHpjnflRz/HFuJWP6
8qjEo7g9KxR9/XQPaG+zYfpMgFgNvaI5z6O5x5ci+3NvTIwh7JoxUVZlFx19Zt5O
E98NWcohCF+PNS6u1VC6
=qNIo
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
pkg-multimedia-maintainers mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
