Hi Jaromír, > 1. Bump of standards version > 3. Use cgit for Vcs-Browser would be probably better. > 4. Is d/dir file needed ?
Thanks for the review! I have pushed the above changes in https://anonscm.debian.org/cgit/pkg-multimedia/xwax.git/commit/?id=b26871620a6f5187d73907a684774477324f0045 > 2. Fix of hardening As this is a real-time audio application, should hardening be applied if it has a performance penalty? Does it offer any genuine security advantage for a desktop application? https://lintian.debian.org/tags/hardening-no-pie.html says "PIE has been associated with noticeable performance overhead on i386. However, GCC-5 has implemented an optimization that can reduce the overhead significantly." As jessie provides gcc 4.9.2 and my aim is to provide a backport, it seems like there could be a performance hit. > 5. Is parallel build now default or should be enabled? The debian/rules file is very customised, I don't see any parallel build options used there at the moment. > 6. I would add d/source/local-options file Is this file still needed even when the upstream source is no longer patched? The previous patch supporting avconv was now merged upstream. Cheers! Daniel _______________________________________________ pkg-multimedia-maintainers mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
