On 24/06/2011 21:50, Mònica Ramírez Arceda wrote:
> I uploaded it but it seems that git-import-dsc ignores the .ds
> extension. I renamed the files of pristine-tar archives and now it works
> (at least, for me).
> I also uploaded the package to mentors:
> dget 
> http://mentors.debian.net/debian/pool/main/m/mkgmapgui/mkgmapgui_1.1.ds-1.dsc
>> The package looks very good and I'll probably sponsor it. But I need to
>> be able to compile it, of course! :-)
> Hopefully, now you can :-)

Just a few comments:

 * Both the website and readme.txt suggest to run mkgmapgui with at
least 512 MB of memory (i.e., with option -Xmx512M). Your script doesn't
do it: you just forgot it or you have reasons to believe it's not
needed? Did you test it on big data sets?

 * More generally, please consider making your wrapper script a bit more
flexible: usually they select the Java VM or its calling options basing
on environment variables. For example, consider the wrapper script for
josm (this is not a requirement for my sponsorship, but I encourage you
to at least consider it).

 * The description can be improved: while the short synopsis is ok, the
long description mostly describes mkgmap instead of mkgmapgui; moreover,
this description doesn't make much sense to people that don't know what
Osm and Img are; I'd suggest to use something like this instead:

mkgmapgui is a GUI front end to mkgmap, a command-line utility for
converting OpenStreetMap map files to files that can be uploaded to a
Garmin GPS device.

While not all the advanced feature of mkgmap are implemented in
mkgmapgui, the most used are: beside converting .osm files to the Garmin
.img format, it's able to combine multiple .img files into one bigger file.

Other than this, your package appears good. Let me know about these
issues and I'll do the sponsoring. :-)

Giovanni Mascellani <mascell...@poisson.phc.unipi.it>
Pisa, Italy

Web: http://poisson.phc.unipi.it/~mascellani
Jabber: g.mascell...@jabber.org / giova...@elabor.homelinux.org

Attachment: signature.asc
Description: OpenPGP digital signature

Pkg-osm-maint mailing list

Reply via email to